Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get.sh to select between --version and version subcommand #674

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

kishen-v
Copy link
Contributor

Binary already exists in path :


VERSION=v0.1.15 ./get.sh

To replace an old version of pvsadm, run this script with an environment variable: FORCE=1

pvsadm is already installed!
Version: v0.1.15, GoVersion: go1.21.11
-----------
VERSION=v0.1.18 ./get.sh. <- manually built from source with the version tag set to 1.18

To replace an old version of pvsadm, run this script with an environment variable: FORCE=1

pvsadm is already installed!
Version: 0.18.0 GoVersion: go1.22.4

A binary is required to be installed

VERSION=v0.1.15 ./get.sh

To replace an old version of pvsadm, run this script with an environment variable: FORCE=1

############################################################################################################# 100.0%
Version: v0.1.15, GoVersion: go1.21.11

Additional notes:
0.1.16 does also seem to report of the API key required to be set : #664.

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 23, 2024
@kishen-v
Copy link
Contributor Author

Additional note: the builds of 0.1.16 are affected too, which may require phasing out the release binary.

@ppc64le-cloud-bot ppc64le-cloud-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 23, 2024
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2024
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishen-v, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2024
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit d2d3bd1 into ppc64le-cloud:main Sep 23, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants