Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pvsadm version also needs api-key now #664

Closed
mkumatag opened this issue Sep 19, 2024 · 1 comment · Fixed by #669
Closed

pvsadm version also needs api-key now #664

mkumatag opened this issue Sep 19, 2024 · 1 comment · Fixed by #669
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mkumatag
Copy link
Member

What happened:

% pvsadm version
Error: api-key can't be empty, pass the token via --api-key or set IBMCLOUD_APIKEY environment variable
Usage:
  pvsadm version [flags]

Flags:
  -h, --help   help for version

Global Flags:
      --add_dir_header                   If true, adds the file directory to the header of the log messages
      --alsologtostderr                  log to standard error as well as files (no effect when -logtostderr=true)
  -k, --api-key string                   IBMCLOUD API Key(env name: IBMCLOUD_APIKEY)
      --audit-file string                Audit logs for the tool (default "pvsadm_audit.log")
      --debug                            Enable PowerVS debug option(ATTENTION: dev only option, may print sensitive data from APIs)
      --env string                       IBM Cloud Environments, supported are: [test, prod] (default "prod")
      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
      --log_dir string                   If non-empty, write log files in this directory (no effect when -logtostderr=true)
      --log_file string                  If non-empty, use this log file (no effect when -logtostderr=true)
      --log_file_max_size uint           Defines the maximum size a log file can grow to (no effect when -logtostderr=true). Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
      --logtostderr                      log to standard error instead of files (default true)
      --one_output                       If true, only write logs to their native severity level (vs also writing to each lower severity level; no effect when -logtostderr=true)
      --skip_headers                     If true, avoid header prefixes in the log messages
      --skip_log_headers                 If true, avoid headers when opening log files (no effect when -logtostderr=true)
      --stderrthreshold severity         logs at or above this threshold go to stderr when writing to files and stderr (no effect when -logtostderr=true or -alsologtostderr=true) (default 2)
  -v, --v Level                          number for the log level verbosity
      --vmodule moduleSpec               comma-separated list of pattern=N settings for file-filtered logging

E0919 16:18:06.019741   37672 main.go:26] api-key can't be empty, pass the token via --api-key or set IBMCLOUD_APIKEY environment variable

What you expected to happen:

This should return the version instead of returning error for the api-key

How to reproduce it (as minimally and precisely as possible):

pvsadm version

Anything else we need to know?:

This is broken after the recent code change cc @kishen-v

Environment:

  • pvsadm version (use pvsadm version):
  • Environment - On-Prem or IBM PowerVS:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Others:
@mkumatag mkumatag added the kind/bug Categorizes issue or PR as related to a bug. label Sep 19, 2024
@ppc64le-cloud ppc64le-cloud deleted a comment from Kami-prog Sep 19, 2024
@kishen-v
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants