get.sh fails with unknown flag: --version error

[mkumatag]

What happened:

+ curl -sL https://raw.githubusercontent.com/ppc64le-cloud/pvsadm/master/get.sh
+ VERSION=v0.1.8 FORCE=1 bash
#=#=#                                                                         
##O#-#                                                                        

                                                                           0.1%
##############################################                            64.1%
######################################################################## 100.0%
Error: unknown flag: --version
Usage:
  pvsadm [command]

Available Commands:
  completion  Generate the autocompletion script for the specified shell
  create      Create the resources
  delete      Delete the resources
  dhcp-sync   dhcp-sync command
  dhcpserver  dhcpserver command
  get         Get the resources
  help        Help about any command
  image       PowerVS Image management
  purge       Purge the powervs resources
  version     Print the version number

Flags:
  -k, --api-key string                   IBMCLOUD API Key(env name: IBMCLOUD_API_KEY)
      --env string                       IBM Cloud Environments, supported are: [prod, test] (default "prod")
      --debug                            Enable PowerVS debug option(ATTENTION: dev only option, may print sensitive data from APIs)
      --audit-file string                Audit logs for the tool (default "pvsadm.log")
      --add_dir_header                   If true, adds the file directory to the header of the log messages
      --alsologtostderr                  log to standard error as well as files (no effect when -logtostderr=true)
      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
      --log_dir string                   If non-empty, write log files in this directory (no effect when -logtostderr=true)
      --log_file string                  If non-empty, use this log file (no effect when -logtostderr=true)
      --log_file_max_size uint           Defines the maximum size a log file can grow to (no effect when -logtostderr=true). Unit is megabytes. If the value is 0, the maximum file size is unlimited. (default 1800)
      --logtostderr                      log to standard error instead of files (default true)
      --one_output                       If true, only write logs to their native severity level (vs also writing to each lower severity level; no effect when -logtostderr=true)
      --skip_headers                     If true, avoid header prefixes in the log messages
      --skip_log_headers                 If true, avoid headers when opening log files (no effect when -logtostderr=true)
      --stderrthreshold severity         logs at or above this threshold go to stderr when writing to files and stderr (no effect when -logtostderr=true or -alsologtostderr=false) (default 2)
  -v, --v Level                          number for the log level verbosity
      --vmodule moduleSpec               comma-separated list of pattern=N settings for file-filtered logging
  -h, --help                             help for pvsadm

Use "pvsadm [command] --help" for more information about a command.

job ref: https://jenkins.ppc64le-cloud.cis.ibm.net/job/powervs/job/ipi/job/4.16/job/daily-ipi4.16-powervs-frankfurt1/116/execution/node/36/log/

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

• pvsadm version (use pvsadm --version):
• Environment - On-Prem or IBM PowerVS:
• OS (e.g: cat /etc/os-release):
• Kernel (e.g. uname -a):
• Others:

[kishen-v]

The changes are made to use the --version flag for >=0.1.18, and version subcommand for the versions priors to the release. This ensures that the appropriate command is executed based on the version.

However, with 0.17.0, as the version command is broken due to #664. An option to delete and re-release the changes can help to fix the breaking change.

With future versions, if we try to run get.sh, while a version > 0.1.18 if it is already installed on the host, the subcommand option will tend to execute, which is bound for deprecation as the locals vars would default to 0(s).

Ps: As discussed, we can plan to deprecate the version sub-command in a major release.

Thanks!

[kishen-v]

Fixed through #674
/close

[ppc64le-cloud-bot]

@kishen-v: Closing this issue.

In response to this:

Fixed through #674
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.