Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade spfx version on js-display-list to 1.11.00 #1465

Merged
merged 5 commits into from
Sep 2, 2020
Merged

upgrade spfx version on js-display-list to 1.11.00 #1465

merged 5 commits into from
Sep 2, 2020

Conversation

sharepointknight
Copy link
Contributor

Q A
Bug fix? no
New feature? no
New sample? no
Related issues?

What's in this Pull Request?

Upgraded sample js-display-list to SPFX 1.11.00

@hugoabernier
Copy link
Collaborator

hugoabernier commented Aug 29, 2020

Thank you @sharepointknight . I've taken the liberty of updating the README and the package/solution version to reflect the changes.

I noticed that the web part wants to render in a tabular format on the local workbench, but stacks the columns in the hosted workbench. Would you mind taking a look to see if perhaps some CSS have changed with the Fluent UI updates that may cause this?

Local:
image

Hosted:
image

In other words: the web part looks like what it is intended to look like (as per the screen shots in the README.md) on the local workbench, but does not in the hosted workbench.

@sharepointknight
Copy link
Contributor Author

sharepointknight commented Aug 30, 2020 via email

@sharepointknight
Copy link
Contributor Author

sharepointknight commented Aug 30, 2020 via email

@hugoabernier
Copy link
Collaborator

hugoabernier commented Aug 30, 2020

@sharepointknight you can continue to add commits to your original PR as long as it has not been closed, just make sure you pull the changes I made so we don't overwrite each other's changes.

Alternatively, you can let me know what the fix was and I'll add it to the PR for you.

Thanks again for your help with this

@sharepointknight
Copy link
Contributor Author

This has been committed to the PR

@hugoabernier hugoabernier merged commit 43496fe into pnp:master Sep 2, 2020
@hugoabernier
Copy link
Collaborator

Thanks @sharepointknight, it works perfectly now!

hugoabernier added a commit that referenced this pull request Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants