-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade spfx version on js-display-list to 1.11.00 #1465
Conversation
Thank you @sharepointknight . I've taken the liberty of updating the README and the package/solution version to reflect the changes. I noticed that the web part wants to render in a tabular format on the local workbench, but stacks the columns in the hosted workbench. Would you mind taking a look to see if perhaps some CSS have changed with the Fluent UI updates that may cause this? In other words: the web part looks like what it is intended to look like (as per the screen shots in the README.md) on the local workbench, but does not in the hosted workbench. |
Yes I'll look at this.
On Saturday, August 29, 2020, 01:50:49 PM PDT, Hugo Bernier <notifications@github.com> wrote:
Thank you @sharepointknight . I've taken the liberty of updating the README and the package/solution version to reflect the changes.
I noticed that the web part wants to render in a tabular format on the local workbench, but stacks the columns in the hosted workbench. Would you mind taking a look to see if perhaps some CSS have changed with the Fluent UI updates that may cause this?
Local:
Hosted:
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
I have found and fixed the issue for the formatting. What is the best way to incorporate the fix into the PR?
Ryan
On Saturday, August 29, 2020, 08:21:33 PM PDT, Schouten Ryan <ryanttr@yahoo.com> wrote:
Yes I'll look at this.
On Saturday, August 29, 2020, 01:50:49 PM PDT, Hugo Bernier <notifications@github.com> wrote:
Thank you @sharepointknight . I've taken the liberty of updating the README and the package/solution version to reflect the changes.
I noticed that the web part wants to render in a tabular format on the local workbench, but stacks the columns in the hosted workbench. Would you mind taking a look to see if perhaps some CSS have changed with the Fluent UI updates that may cause this?
Local:
Hosted:
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@sharepointknight you can continue to add commits to your original PR as long as it has not been closed, just make sure you pull the changes I made so we don't overwrite each other's changes. Alternatively, you can let me know what the fix was and I'll add it to the PR for you. Thanks again for your help with this |
This has been committed to the PR |
Thanks @sharepointknight, it works perfectly now! |
What's in this Pull Request?
Upgraded sample js-display-list to SPFX 1.11.00