Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Enables user to click on header of an expanded accordion… #1472

Merged
merged 2 commits into from
Sep 3, 2020

Conversation

ejbenke
Copy link
Contributor

@ejbenke ejbenke commented Sep 1, 2020

… item to collapse it (instead of an expanded item only being collapsed when a new item is expanded)

Q A
Bug fix? no
New feature? yes
New sample? no
Related issues? addresses item number 3 of Issue #1407

What's in this Pull Request?

Enhancement to address item 3 of Issue #1407. Sets allowZeroExpanded JSX attribute of the Accordion component to true instead react-accessible-accordion library's default of false. Result is that a user can now collapse an open accordion item by clicking on its header instead of needing to expand another item to force the collapsing of the original.

… item to collapse it (instead of an expanded item only being collapsed when a new item is expanded)
@hugoabernier hugoabernier merged commit 3bacbf7 into pnp:master Sep 3, 2020
@hugoabernier
Copy link
Collaborator

Thank you @ejbenke. I hope you don't mind, but I updated the README and increased the solution version number.

hugoabernier added a commit that referenced this pull request Sep 3, 2020
@ejbenke
Copy link
Contributor Author

ejbenke commented Sep 3, 2020

Thanks @hugoabernier - and thanks also for updating the README and version number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants