Merge pull request #1465 from sharepointknight/master

upgrade spfx version on js-display-list to 1.11.00

samples/js-display-list/.yo-rc.json

@@ -1,7 +1,10 @@
 {
   "@microsoft/generator-sharepoint": {
-    "libraryName": "js-display-list",
-    "libraryId": "faf13055-4551-491c-8bbf-a00b30adfd54",
-    "framework": "none"
+    "version": "1.11.0",
+    "isDomainIsolated": false,
+    "isCreatingSolution": true,
+    "packageManager": "npm",
+    "componentType": "webpart",
+    "environment": "spo"
   }
-}
+}

samples/js-display-list/README.md

@@ -14,14 +14,16 @@ extensions:
 # Display List JavaScript Client-Side Web Part
 
 ## Summary
-This simplistic sample Web Part demonstrates the use of JavaScript in a SharePoint Framework web part. The properties pane for this web part display a drop down list of lists in the current web. Once the user selects one of the lists, the web part display the contents of the list.
 
-![Screeshot of the Display List web part](./assets/display-list-preview.png).
+This simplistic sample web part demonstrates the use of JavaScript in a SharePoint Framework web part. The properties pane for this web part display a drop down list of lists in the current web. Once the user selects one of the lists, the web part display the contents of the list.
+
+![Screenshot of the Display List web part](./assets/display-list-preview.png).
 
 > Does only show data when hosted in SharePoint. No mock data at this point for local testing the rendering.
 
 ## Used SharePoint Framework Version
-![drop](https://img.shields.io/badge/drop-GA-green.svg)
+
+![SPFx 1.11.0](https://img.shields.io/badge/drop-1.11.0-green.svg)
 
 ## Applies to
 
@@ -33,8 +35,10 @@ This simplistic sample Web Part demonstrates the use of JavaScript in a SharePoi
 
 Solution|Author(s)
 --------|---------
-js-display-list|Naamat Al-Aswad, P.Eng.
-Updated to GA Version| Velin Georgiev ([@VelinGeorgiev](https://twitter.com/velingeorgiev))
+js-display-list| Naamat Al-Aswad, P.Eng.
+js-display-list| Velin Georgiev ([@VelinGeorgiev](https://twitter.com/velingeorgiev)) (Updated to GA Version)
+js-display-list| Ryan Schouten ([@ShrPntKnight](https://twitter.com/ShrPntKnight)) (Upgraded to SPFx 1.11.0)
+
 
 
 ## Version history
@@ -43,9 +47,11 @@ Version|Date|Comments
 -------|----|--------
 1.0|September 22, 2016|Initial release
 1.1|May 15, 2017|Updated to GA Version
+2.0|August 29, 2020|Upgraded to SPFx 1.11.0
 
 
 ## Disclaimer
+
 **THIS CODE IS PROVIDED *AS IS* WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESS OR IMPLIED, INCLUDING ANY IMPLIED WARRANTIES OF FITNESS FOR A PARTICULAR PURPOSE, MERCHANTABILITY, OR NON-INFRINGEMENT.**
 
 ---
@@ -61,6 +67,7 @@ Version|Date|Comments
       - Basic functionality can be tested locally, data is only shown when used in context of SharePoint
 
 ## Features
+
 The js-display-list web part displays the content of the list specified in the web part properties pane.
 
 This Web Part illustrates the following concepts on top of the SharePoint Framework:

samples/js-display-list/config/config.json

@@ -1,11 +1,6 @@
 {
-  "entries": [
-    {
-      "entry": "./lib/webparts/jsDisplayList/JsDisplayListWebPart.js",
-      "manifest": "./src/webparts/jsDisplayList/JsDisplayListWebPart.manifest.json",
-      "outputPath": "./dist/js-display-list.bundle.js"
-    }
-  ],
+  "$schema": "https://developer.microsoft.com/json-schemas/spfx-build/config.2.0.schema.json",
+  "version": "2.0",
   "externals": {
     "@microsoft/sp-client-base": "node_modules/@microsoft/sp-client-base/dist/sp-client-base.js",
     "@microsoft/sp-client-preview": "node_modules/@microsoft/sp-client-preview/dist/sp-client-preview.js",
@@ -16,6 +11,16 @@
     "react-dom/server": "node_modules/react-dom/dist/react-dom-server.min.js"
   },
   "localizedResources": {
-    "jsDisplayListStrings": "webparts/jsDisplayList/loc/{locale}.js"
+    "jsDisplayListStrings": "lib/webparts/jsDisplayList/loc/{locale}.js"
+  },
+  "bundles": {
+    "js-display-list-web-part": {
+      "components": [
+        {
+          "entrypoint": "./lib/webparts/jsDisplayList/JsDisplayListWebPart.js",
+          "manifest": "./src/webparts/jsDisplayList/JsDisplayListWebPart.manifest.json"
+        }
+      ]
+    }
   }
 }

samples/js-display-list/config/deploy-azure-storage.json

@@ -1,4 +1,5 @@
 {
+  "$schema": "https://developer.microsoft.com/json-schemas/spfx-build/deploy-azure-storage.schema.json",
   "workingDir": "./temp/deploy/",
   "account": "<!-- STORAGE ACCOUNT NAME -->",
   "container": "js-display-list",

samples/js-display-list/config/package-solution.json

@@ -1,8 +1,11 @@
 {
+  "$schema": "https://developer.microsoft.com/json-schemas/spfx-build/package-solution.schema.json",
   "solution": {
     "name": "js-display-list-client-side-solution",
     "id": "faf13055-4551-491c-8bbf-a00b30adfd54",
-    "version": "1.0.0.0"
+    "version": "2.0.0.0",
+    "isDomainIsolated": false,
+    "includeClientSideAssets": true
   },
   "paths": {
     "zippedPackage": "solution/js-display-list.spapp"

samples/js-display-list/config/serve.json

@@ -1,4 +1,5 @@
 {
+  "$schema": "https://developer.microsoft.com/json-schemas/core-build/serve.schema.json",
   "port": 4321,
   "initialPage": "https://localhost:5432/workbench",
   "https": true,

samples/js-display-list/config/write-manifests.json

@@ -1,3 +1,4 @@
 {
+  "$schema": "https://developer.microsoft.com/json-schemas/spfx-build/write-manifests.schema.json",
   "cdnBasePath": "<!-- PATH TO CDN -->"
 }

samples/js-display-list/gulpfile.js

@@ -2,5 +2,5 @@
 
 const gulp = require('gulp');
 const build = require('@microsoft/sp-build-web');
-
+build.addSuppression(`Warning - [sass] The local CSS class 'ms-Grid' is not camelCase and will not be type-safe.`);
 build.initialize(gulp);