This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Send which input fired in update request. #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/actions/index.js
Outdated
| @@ -356,7 +357,8 @@ function updateOutput( | |||
| outputProp, | |||
| getState, | |||
| requestUid, | |||
| dispatch | |||
| dispatch, | |||
| changedProps, | |||
There was a problem hiding this comment.
Per our slack discussion this morning, I guess change this to changedPropIds?
There was a problem hiding this comment.
Yes, also filtering the inputs that are not connected.
6c372f1 to
0c616dd
Compare
0c616dd to
e6a2158
Compare
alexcjohnson
approved these changes
Feb 14, 2019
Yes almost everything was in place for this in the renderer... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plotly/dash#291 & plotly/dash#608