🔨 Filter changed props that are not connected to the inputs.

plotly · Feb 14, 2019 · e6a2158 · e6a2158
1 parent 8136212
commit e6a2158
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 9 deletions.
diff --git a/dash_renderer/dash_renderer.dev.js b/dash_renderer/dash_renderer.dev.js
@@ -34023,7 +34023,7 @@ function notifyObservers(payload) {
     };
 }
 
-function updateOutput(outputComponentId, outputProp, getState, requestUid, dispatch, changedProps) {
+function updateOutput(outputComponentId, outputProp, getState, requestUid, dispatch, changedPropIds) {
     var _getState3 = getState(),
         config = _getState3.config,
         layout = _getState3.layout,
@@ -34044,7 +34044,7 @@ function updateOutput(outputComponentId, outputProp, getState, requestUid, dispa
 
     var payload = {
         output: { id: outputComponentId, property: outputProp },
-        changedProps: changedProps
+        changedPropIds: changedPropIds
     };
 
     var _dependenciesRequest$ = dependenciesRequest.content.find(function (dependency) {
@@ -34068,6 +34068,14 @@ function updateOutput(outputComponentId, outputProp, getState, requestUid, dispa
         };
     });
 
+    var inputsPropIds = inputs.map(function (p) {
+        return p.id + '.' + p.property;
+    });
+
+    payload.changedPropIds = changedPropIds.filter(function (p) {
+        return (0, _ramda.contains)(p, inputsPropIds);
+    });
+
     if (state.length > 0) {
         payload.state = state.map(function (stateObject) {
             // Make sure the component id exists in the layout
@@ -34291,7 +34299,7 @@ function updateOutput(outputComponentId, outputProp, getState, requestUid, dispa
                             uid: requestUid,
                             requestTime: Date.now()
                         }, getState().requestQueue)));
-                        updateOutput(idAndProp.split('.')[0], idAndProp.split('.')[1], getState, requestUid, dispatch);
+                        updateOutput(idAndProp.split('.')[0], idAndProp.split('.')[1], getState, requestUid, dispatch, changedPropIds);
                     });
                 }
             }

diff --git a/dash_renderer/dash_renderer.dev.js.map b/dash_renderer/dash_renderer.dev.js.map
diff --git a/dash_renderer/dash_renderer.min.js b/dash_renderer/dash_renderer.min.js
diff --git a/dash_renderer/dash_renderer.min.js.map b/dash_renderer/dash_renderer.min.js.map
diff --git a/src/actions/index.js b/src/actions/index.js
@@ -358,7 +358,7 @@ function updateOutput(
     getState,
     requestUid,
     dispatch,
-    changedProps,
+    changedPropIds,
 ) {
     const {config, layout, graphs, paths, dependenciesRequest} = getState();
     const {InputGraph} = graphs;
@@ -373,7 +373,7 @@ function updateOutput(
      */
     const payload = {
         output: {id: outputComponentId, property: outputProp},
-        changedProps
+        changedPropIds
     };
 
     const {inputs, state} = dependenciesRequest.content.find(
@@ -409,6 +409,12 @@ function updateOutput(
         };
     });
 
+    const inputsPropIds = inputs.map(p => `${p.id}.${p.property}`);
+
+    payload.changedPropIds = changedPropIds.filter(
+        p => contains(p, inputsPropIds)
+    );
+
     if (state.length > 0) {
         payload.state = state.map(stateObject => {
             // Make sure the component id exists in the layout
@@ -706,7 +712,8 @@ function updateOutput(
                             idAndProp.split('.')[1],
                             getState,
                             requestUid,
-                            dispatch
+                            dispatch,
+                            changedPropIds
                         );
                     });
                 }