Merge pull request #124 from plotly/callback-context

Send which input fired in update request.
plotly · Feb 21, 2019 · 5c7252e · 5c7252e
2 parents 897cbce + e6a2158
commit 5c7252e
Show file tree

Hide file tree

Showing 6 changed files with 35 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## UNRELEASED
+## Added
+- Added which properties fired to update prop request. [#124](https://github.com/plotly/dash-renderer/pull/124)
+
 ## [0.18.0] - 2019-02-11
 ### Removed
 - Removed redux logger for the dev. [#118](https://github.com/plotly/dash-renderer/pull/118)

diff --git a/dash_renderer/dash_renderer.dev.js b/dash_renderer/dash_renderer.dev.js
@@ -34012,7 +34012,9 @@ function notifyObservers(payload) {
 
             var requestUid = newRequestQueue[i].uid;
 
-            promises.push(updateOutput(outputComponentId, outputProp, getState, requestUid, dispatch));
+            promises.push(updateOutput(outputComponentId, outputProp, getState, requestUid, dispatch, changedProps.map(function (prop) {
+                return id + '.' + prop;
+            })));
         }
 
         /* eslint-disable consistent-return */
@@ -34021,7 +34023,7 @@ function notifyObservers(payload) {
     };
 }
 
-function updateOutput(outputComponentId, outputProp, getState, requestUid, dispatch) {
+function updateOutput(outputComponentId, outputProp, getState, requestUid, dispatch, changedPropIds) {
     var _getState3 = getState(),
         config = _getState3.config,
         layout = _getState3.layout,
@@ -34041,7 +34043,8 @@ function updateOutput(outputComponentId, outputProp, getState, requestUid, dispa
      */
 
     var payload = {
-        output: { id: outputComponentId, property: outputProp }
+        output: { id: outputComponentId, property: outputProp },
+        changedPropIds: changedPropIds
     };
 
     var _dependenciesRequest$ = dependenciesRequest.content.find(function (dependency) {
@@ -34065,6 +34068,14 @@ function updateOutput(outputComponentId, outputProp, getState, requestUid, dispa
         };
     });
 
+    var inputsPropIds = inputs.map(function (p) {
+        return p.id + '.' + p.property;
+    });
+
+    payload.changedPropIds = changedPropIds.filter(function (p) {
+        return (0, _ramda.contains)(p, inputsPropIds);
+    });
+
     if (state.length > 0) {
         payload.state = state.map(function (stateObject) {
             // Make sure the component id exists in the layout
@@ -34288,7 +34299,7 @@ function updateOutput(outputComponentId, outputProp, getState, requestUid, dispa
                             uid: requestUid,
                             requestTime: Date.now()
                         }, getState().requestQueue)));
-                        updateOutput(idAndProp.split('.')[0], idAndProp.split('.')[1], getState, requestUid, dispatch);
+                        updateOutput(idAndProp.split('.')[0], idAndProp.split('.')[1], getState, requestUid, dispatch, changedPropIds);
                     });
                 }
             }

diff --git a/dash_renderer/dash_renderer.dev.js.map b/dash_renderer/dash_renderer.dev.js.map
diff --git a/dash_renderer/dash_renderer.min.js b/dash_renderer/dash_renderer.min.js
diff --git a/dash_renderer/dash_renderer.min.js.map b/dash_renderer/dash_renderer.min.js.map
diff --git a/src/actions/index.js b/src/actions/index.js
@@ -340,7 +340,8 @@ export function notifyObservers(payload) {
                     outputProp,
                     getState,
                     requestUid,
-                    dispatch
+                    dispatch,
+                    changedProps.map(prop => `${id}.${prop}`)
                 )
             );
         }
@@ -356,7 +357,8 @@ function updateOutput(
     outputProp,
     getState,
     requestUid,
-    dispatch
+    dispatch,
+    changedPropIds,
 ) {
     const {config, layout, graphs, paths, dependenciesRequest} = getState();
     const {InputGraph} = graphs;
@@ -371,6 +373,7 @@ function updateOutput(
      */
     const payload = {
         output: {id: outputComponentId, property: outputProp},
+        changedPropIds
     };
 
     const {inputs, state} = dependenciesRequest.content.find(
@@ -406,6 +409,12 @@ function updateOutput(
         };
     });
 
+    const inputsPropIds = inputs.map(p => `${p.id}.${p.property}`);
+
+    payload.changedPropIds = changedPropIds.filter(
+        p => contains(p, inputsPropIds)
+    );
+
     if (state.length > 0) {
         payload.state = state.map(stateObject => {
             // Make sure the component id exists in the layout
@@ -703,7 +712,8 @@ function updateOutput(
                             idAndProp.split('.')[1],
                             getState,
                             requestUid,
-                            dispatch
+                            dispatch,
+                            changedPropIds
                         );
                     });
                 }