-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.3.0 #217
Merged
Release 1.3.0 #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few random cleanups
This will remove the dependency on JSON2.
update to DashBase 0.2
Update Installation instructions
Update Project Status
Test on Julia 1.9
Update `lint.yml`
- update maintainer info ;) - use `cimg/python:3.9.9-browsers`, copied from the dash `.circleci/config.yml` - install Julia 1.9.1
created using the `build/Dockerfile` and pushed to hub.docker.com by me.
our docker image extends from `cimg/python-3.9-browsers` which does not install the chromedriver by default, this is now done using a CircleCI "orb"
these didn't run since we updated our HTTP dep back in `v1.2.0`
now done using a CircleCI "orb". While the percy snapshot test still fails (fixing this will requires "approval" on percy.io), the percy snapshots now get properly uploaded to percy.io, making them available for viewing.
Update docker image [final]
which is more general than just ignoring `node_modules`
for all git-tracked text files, assert that: - No trainling whitespaces at EOLs - No tab characters - a newline at EOF
so that the `lint.yml` workflow passes
as the recent versions of dash (> 1.21.0) have the `dash_renderer` merged within the dash repo. Namely, we need - grab the `dash_renderer` module from the main `dash` module - to override the `namespace` value with `"dash_renderer" to fetch from the correct URL, we do something similar for the renderer deps just above.
bump the version to use in `Sources.toml` then commmit the updated `Artifacts.toml` after `generate.jl --deploy` pointing to https://github.com/plotly/DashCoreResources/releases/tag/v2.10.2%2B0
clientside callbacks with Promises are now supported by dash since v2.4.0
`invalid-nested-prop` became `allow-nested-prop` in dash 2.1.0 moreover, use same css query as in the python version of the `test_props_check.py` suite
Next-generation `gen_resources`
add index by id
Add CONTRIBUTING.md
as use in the plotly/dash README
- move up project description - drop reference to 2+ year old Python version that added support Julia/R components creation - use `julia` code snippets instead of `jldoctest` for better highlighting - use Input/State splat style over `[Inputs]`, `[States]` style - drop info on the `dash` constructor which was mostly outdated and too advanced for a README - add more info on JSON3 serialization
A few improvements to the repo README
Requesting approval from https://github.com/waralexrom or @alexcjohnson - thanks! |
that's @waralexrom - my mistake 😄 |
alexcjohnson
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't comment on ALL the details but I'm on board with all the PRs included here and excited to see the release, so 💃 from me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI
documentation
Improvements or additions to documentation
enhancement
New feature or request
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
getindex
method byid
forapp.layout
and components add index by id #203Changed
v2.10.2
Next-generationgen_resources
#212, with additions such as:dcc_geolocation
dcc_markdown
anddcc_graph
disable_n_clicks
dcc_dropdown
propssearch
andmaxHeight
"0.2"
(JSON2 is longer installed) update to DashBase 0.2 #194Internal
Tech debt
gen_resources
#212lint.yml
#206, Lint all the files #210,Tests
Docs
New Contributors