-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add index by id #203
add index by id #203
Conversation
Hi @BeastyBlacksmith - nice to see someone making a feature PR to Dash.jl ! Does the python version of dash expose something similar from its public API or its testing API? If so, I think we could safely merge your PR. If not, I (not a Plotly employee, I'm just a Dash.jl user with write rights to this repo) wouldn't be comfortable making the Dash.jl API diverge from the python version of dash. |
I don't think it gets a lot of use, but Python Dash does allow you to find components within any component tree by ID: >>> from dash import html
>>> container = html.Div([html.Div(id="a"), html.Div(id="b")])
>>> container['a']
Div(id='a') It's a little funny to me that what you have here is |
They work both |
bump.
Should I add a test for this? |
Hi @BeastyBlacksmith, if you were to remove the |
I don't think it does any harm, but I removed it. |
Thanks for the PR @BeastyBlacksmith - merging ! |
This adds the ability to index into
DashApp
,Components
and collections ofComponents
by id. LikeThis is mainly useful for testing purposes and a convenience feature.