Update docker image [final] #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update maintainer info ;) - use `cimg/python:3.9.9-browsers`, copied from the dash `.circleci/config.yml` - install Julia 1.9.1
created using the `build/Dockerfile` and pushed to hub.docker.com by me.
our docker image extends from `cimg/python-3.9-browsers` which does not install the chromedriver by default, this is now done using a CircleCI "orb"
these didn't run since we updated our HTTP dep back in `v1.2.0`
now done using a CircleCI "orb". While the percy snapshot test still fails (fixing this will requires "approval" on percy.io), the percy snapshots now get properly uploaded to percy.io, making them available for viewing.
|
The Percy snapshot tests (more in #177) are still failing, but everything else is green. Merging! |
This was referenced Jun 12, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a cleaned-up verison of #205, resolves #186, bringing the integration tests back to life 🎉
Please note: the CircleCI runs now pull the
etpinard/dashjl-testscontainer. I'm using my personal docker hub account, since I do not have push rights to the Plotly docker hub account (and I don't need to 😄 )