-
Notifications
You must be signed in to change notification settings - Fork 101
mock: enable the mock package only in unit tests #838
Conversation
LGTM |
Do we need to update the project document since after this change, run |
@glorv I thought we only support |
It's convenient to run Developers (like me?) for community may came across this issue if they forget to add the |
/merge |
@AndreMouche Oops! auto merge is restricted to Committers of the SIG.See the corresponding SIG page for more information. Related SIG: migrate(slack). |
I would like to merge this PR, could we open another PR to fix it? |
/run-all-tests |
@AndreMouche well we need one more LGTM anyway 🙃 PTAL @glorv the latest commit |
/lgtm |
/merge |
/run-all-tests |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #842 |
It can not fix #837, sad. TiDB still can not work with the |
@AndreMouche have you reverted the protobuf upgrade in https://github.com/pingcap/tidb/pull/23183/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6L21 yet |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
This reverts commit 03fa063.
What problem does this PR solve?
Close #837. Allows TiDB to depend on BR without pulling in Lightning's dependencies yet.
What is changed and how it works?
Make the
mock
package (currently depending onbackend
package which in turn pulls inpebble
and the whole tree) require the build tagbr_test
. The tag is only active in unit tests.Check List
Tests
Code changes
mock
package is no longer allowed outside of unit tests.Side effects
Related changes
Release Note