mock: enable the mock package only in unit tests

pingcap · Mar 10, 2021 · 047ea6a · 047ea6a
1 parent 6e1a8ca
commit 047ea6a
Show file tree

Hide file tree

Showing 10 changed files with 25 additions and 4 deletions.
diff --git a/Makefile b/Makefile
@@ -114,7 +114,7 @@ build_for_integration_test:
 test:
 	$(PREPARE_MOD)
 	@make failpoint-enable
-	$(GOTEST) $(RACEFLAG) -tags leak $$($(PACKAGES)) || ( make failpoint-disable && exit 1 )
+	$(GOTEST) $(RACEFLAG) -tags br_test,leak $$($(PACKAGES)) || ( make failpoint-disable && exit 1 )
 	@make failpoint-disable
 
 testcover: tools
@@ -188,7 +188,7 @@ static: prepare tools
 	@#   exhaustivestruct - Protobuf structs have hidden fields, like "XXX_NoUnkeyedLiteral"
 	@#         exhaustive - no need to check exhaustiveness of enum switch statements
 	@#              gosec - too many false positive
-	CGO_ENABLED=0 tools/bin/golangci-lint run --enable-all --deadline 120s \
+	CGO_ENABLED=0 tools/bin/golangci-lint run --enable-all --build-tags br_test --deadline 120s \
 		--disable gochecknoglobals \
 		--disable goimports \
 		--disable gofmt \

diff --git a/pkg/mock/backend.go b/pkg/mock/backend.go
diff --git a/pkg/mock/dummy.go b/pkg/mock/dummy.go
@@ -0,0 +1,5 @@
+// Copyright 2021 PingCAP, Inc. Licensed under Apache-2.0.
+
+// This file avoids mock being an empty package when `-tags br_test` is not provided.
+
+package mock
diff --git a/pkg/mock/glue.go b/pkg/mock/glue.go
diff --git a/pkg/mock/glue_checkpoint.go b/pkg/mock/glue_checkpoint.go
diff --git a/pkg/mock/importer.go b/pkg/mock/importer.go
diff --git a/pkg/mock/mock_cluster.go b/pkg/mock/mock_cluster.go
@@ -1,5 +1,7 @@
 // Copyright 2020 PingCAP, Inc. Licensed under Apache-2.0.
 
+//+build br_test
+
 package mock
 
 import (

diff --git a/pkg/mock/mock_cluster_test.go b/pkg/mock/mock_cluster_test.go
@@ -1,5 +1,7 @@
 // Copyright 2020 PingCAP, Inc. Licensed under Apache-2.0.
 
+//+build br_test
+
 package mock_test
 
 import (

diff --git a/pkg/mock/s3iface.go b/pkg/mock/s3iface.go
diff --git a/pkg/mock/storage.go b/pkg/mock/storage.go