This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
lightning: refactor the backend
package (#877)
#902
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #877 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In br repo: git pr https://github.com/pingcap/br/pull/902
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Split the
pkg/lightning/backend
package into multiple parts, intended to be the true fix for #837 survivinggo mod tidy
.What is changed and how it works?
The
backend
package itself now only contains the abstract typeBackend
. The concrete stuff are now split into multiple subpackages:pkg/lightning/backend/local
pkg/lightning/backend/tidb
pkg/lightning/backend/importer
pkg/lightning/backend/kv
, intended to be merged intopkg/kv
in some future PRpkg/lightning/tikv
pkg/lightning/backend/importer
, pkg/lightning/backend/local,
pkg/lightning/tikvand
pkg/version` depending on the component being checked.Reverted #838 as it is proved to be useless.
Check List
Tests
Code changes
Side effects
Related changes
Release Note