-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variable resolution and dynamic lookup fixes #416
Conversation
Conformance comparison report
Number passing in both: 5595 Number failing in both: 722 Number passing in Base (59a5fb1) but now fail: 0 Number failing in Base (59a5fb1) but now pass: 8 The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass: Click here to see
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
==========================================
+ Coverage 81.74% 81.82% +0.07%
==========================================
Files 62 62
Lines 15426 15548 +122
Branches 15426 15548 +122
==========================================
+ Hits 12610 12722 +112
- Misses 2303 2307 +4
- Partials 513 519 +6
☔ View full report in Codecov by Sentry. |
…ref lower to also lower on from vars
RUST_TEST_TIME_UNIT: 150,5000 | ||
RUST_TEST_TIME_INTEGRATION: 150,5000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of the MYSQL tests were failing because they were taking a bit over these time thresholds.
); | ||
} | ||
Err(_) => {} | ||
if let Ok(plan) = plan { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applying some clippy suggestions.
8055cfa
to
a94edc0
Compare
Conformance test regressions (#416 (comment)) are due to updated |
80df645
to
e7b3d81
Compare
638b959
to
bda363e
Compare
Closes #411.
Variable resolution and dynamic lookup would sometimes perform the incorrect lookup order or do too many lookups (e.g. do a global lookup on every local lookup). This PR
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.