Add error catching before .expect() in name_resolver

partiql · Jul 31, 2023 · a94edc0 · a94edc0
1 parent 7023a1e
commit a94edc0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/partiql-ast-passes/src/name_resolver.rs b/partiql-ast-passes/src/name_resolver.rs
@@ -387,9 +387,19 @@ impl<'ast> Visitor<'ast> for NameResolver {
         self.enter_keyref();
         let id = *self.current_node();
 
+        if self
+            .enclosing_clause
+            .get(&EnclosingClause::FromLet)
+            .is_none()
+        {
+            self.errors.push(AstTransformError::IllegalState(
+                "group_key expects a FromLet enclosing clause".to_string(),
+            ))
+        }
+
         self.enclosing_clause
             .get(&EnclosingClause::FromLet)
-            .unwrap()
+            .expect("EnclosingClause::FromLet")
             .iter()
             .for_each(|enclosing_clause| {
                 self.in_scope

diff --git a/partiql-conformance-tests/partiql-tests b/partiql-conformance-tests/partiql-tests