Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box Decimals in Value to assure Value fits in 16 bytes #411

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Conversation

jpschorr
Copy link
Contributor

@jpschorr jpschorr commented Jul 18, 2023

Having a smaller, more uniform, Value size should aide in data density and shows a small improvement on calculation-heavy workloads.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpschorr jpschorr requested review from alancai98 and am357 July 18, 2023 18:49
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 99.01% and project coverage change: -0.01 ⚠️

Comparison is base (d1bdfb0) 81.41% compared to head (7a5bedc) 81.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
- Coverage   81.41%   81.40%   -0.01%     
==========================================
  Files          56       53       -3     
  Lines       14912    14907       -5     
  Branches    14912    14907       -5     
==========================================
- Hits        12140    12135       -5     
  Misses       2251     2251              
  Partials      521      521              
Impacted Files Coverage Δ
partiql-logical-planner/src/lower.rs 85.78% <50.00%> (ø)
extension/partiql-extension-ion/src/decode.rs 77.42% <100.00%> (ø)
partiql-eval/src/eval/evaluable.rs 89.46% <100.00%> (ø)
partiql-eval/src/eval/expr/mod.rs 82.72% <100.00%> (ø)
partiql-value/src/lib.rs 96.45% <100.00%> (+0.03%) ⬆️

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

Conformance comparison report

Base (d1bdfb0) c463732 +/-
% Passing 84.12% 84.12% 0.00%
✅ Passing 5318 5318 0
❌ Failing 1004 1004 0
🔶 Ignored 0 0 0
Total Tests 6322 6322 0

Number passing in both: 5318

Number failing in both: 1004

Number passing in Base (d1bdfb0) but now fail: 0

Number failing in Base (d1bdfb0) but now pass: 0

@jpschorr jpschorr merged commit 309dd6a into main Jul 18, 2023
@jpschorr jpschorr deleted the fix-box-dec branch July 18, 2023 19:15
@jpschorr
Copy link
Contributor Author

jpschorr commented Jan 2, 2024

See 309dd6a#commitcomment-122007994

PartiQL (rust) Benchmark

Benchmark suite Current: 309dd6a Previous: d1bdfb0 Ratio
parse-1 5562 ns/iter (± 162) 6534 ns/iter (± 472) 0.85
parse-15 51507 ns/iter (± 228) 59515 ns/iter (± 396) 0.87
parse-30 101079 ns/iter (± 90) 121699 ns/iter (± 795) 0.83
compile-1 5416 ns/iter (± 23) 6205 ns/iter (± 25) 0.87
compile-15 36476 ns/iter (± 95) 42933 ns/iter (± 78) 0.85
compile-30 73766 ns/iter (± 39) 86644 ns/iter (± 174) 0.85
plan-1 62788 ns/iter (± 199) 75216 ns/iter (± 222) 0.83
plan-15 992396 ns/iter (± 4118) 1212825 ns/iter (± 4490) 0.82
plan-30 1994707 ns/iter (± 3420) 2432922 ns/iter (± 11089) 0.82
eval-1 22185744 ns/iter (± 230734) 26858891 ns/iter (± 398062) 0.83
eval-15 125747983 ns/iter (± 504860) 144390233 ns/iter (± 805477) 0.87
eval-30 245001105 ns/iter (± 419301) 272423461 ns/iter (± 579099) 0.90
join 14698 ns/iter (± 89) 18172 ns/iter (± 43) 0.81
simple 7195 ns/iter (± 6) 8274 ns/iter (± 18) 0.87
simple-no 697 ns/iter (± 0) 885 ns/iter (± 2) 0.79
numbers 47 ns/iter (± 0) 173 ns/iter (± 1) 0.27
parse-simple 762 ns/iter (± 4) 888 ns/iter (± 49) 0.86
parse-ion 2532 ns/iter (± 63) 2796 ns/iter (± 104) 0.91
parse-group 7870 ns/iter (± 21) 8964 ns/iter (± 41) 0.88
parse-complex 19997 ns/iter (± 85) 24322 ns/iter (± 121) 0.82
parse-complex-fexpr 28494 ns/iter (± 117) 34943 ns/iter (± 146) 0.82

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants