Add experimental draft support for GPML-style graph query #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
am357
reviewed
Jun 27, 2022
am357
previously approved these changes
Jun 27, 2022
alancai98
reviewed
Jun 28, 2022
| @@ -585,7 +590,7 @@ internal const val DIGIT_CHARS = "0" + NON_ZERO_DIGIT_CHARS | |||
|
|
|||
| @JvmField internal val E_NOTATION_CHARS = allCase("E") | |||
|
|
|||
| internal const val NON_OVERLOADED_OPERATOR_CHARS = "^%=@+" | |||
| internal const val NON_OVERLOADED_OPERATOR_CHARS = "^%=@+~" | |||
| internal const val OPERATOR_CHARS = NON_OVERLOADED_OPERATOR_CHARS + "-*/<>|!" | |||
There was a problem hiding this comment.
Hmm, just noticed the OPERATOR_CHARS variable isn't used anywhere. Can it be removed?
Comment on lines
+3580
to
+3594
| } catch (e: ParserException) { | ||
| null | ||
| } | ||
| patterns.add(nodeLeft) | ||
| do { | ||
| val edge = try { | ||
| parseEdge() | ||
| } catch (e: ParserException) { | ||
| null | ||
| } | ||
| patterns.add(edge) | ||
| val nodeRight = try { | ||
| parseNode() | ||
| } catch (e: ParserException) { | ||
| null |
There was a problem hiding this comment.
Why do these return null when there's a ParserException?
Co-authored-by: Alan Cai <caialan@amazon.com>
alancai98
approved these changes
Jun 28, 2022
Merged
This was referenced Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the exploration of #689
This adds draft parser/AST support for a subset of GPML as outlined by Graph Pattern Matching in GQL and SQL/PGQ. The use within the grammar is based on the assumption of a new graph data type being added to the specification of data types within PartiQL, and should be considered experimental until the semantics of the graph data type are specified.
This adds support for parsing:
TODO:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.