Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor GPML Match clause clean-up #663

Merged
merged 2 commits into from
Jul 8, 2022
Merged

Minor GPML Match clause clean-up #663

merged 2 commits into from
Jul 8, 2022

Conversation

jpschorr
Copy link
Contributor

@jpschorr jpschorr commented Jul 7, 2022

Part of the exploration of #689

Minor clean-up after #652 and #658 :

  • Clean up some linter warnings
  • Require parentheses around implicitly joined (via comma) graph patterns in the MATCH clause.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpschorr jpschorr requested review from alancai98 and am357 July 7, 2022 18:01
@codecov-commenter
Copy link

Codecov Report

Merging #663 (da319dc) into main (bf2696f) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff            @@
##               main     #663   +/-   ##
=========================================
  Coverage     79.61%   79.61%           
  Complexity     2349     2349           
=========================================
  Files           236      236           
  Lines         19345    19336    -9     
  Branches       3765     3764    -1     
=========================================
- Hits          15401    15394    -7     
+ Misses         2657     2656    -1     
+ Partials       1287     1286    -1     
Flag Coverage Δ
CLI 22.68% <ø> (ø)
EXAMPLES 76.24% <ø> (ø)
EXTENSIONS 69.23% <ø> (ø)
LANG 81.67% <50.00%> (+<0.01%) ⬆️
PTS ∅ <ø> (∅)
TEST_SCRIPT 77.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lang/src/org/partiql/lang/syntax/SqlParser.kt 77.75% <50.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf2696f...da319dc. Read the comment docs.

@jpschorr jpschorr merged commit 1117acd into main Jul 8, 2022
@jpschorr jpschorr deleted the graph-query-cleanup branch July 8, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants