Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr template update #655

Merged
merged 3 commits into from
Jun 28, 2022
Merged

Pr template update #655

merged 3 commits into from
Jun 28, 2022

Conversation

am357
Copy link
Contributor

@am357 am357 commented Jun 28, 2022

Issue #, if available:

Description of changes:
Adds the new questions to the PR process for backward-incompatibility and introduction of new dependencies.

Have you updated the Unreleased section of CHANGELOG.md with your changes? (y/n) If not, please explain why:
yes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

am357 added 2 commits June 28, 2022 13:34
Updating the tempalate so we can have more context on the included
backward incompatible and dependency changes in the PRs.
@am357 am357 self-assigned this Jun 28, 2022
@am357 am357 marked this pull request as ready for review June 28, 2022 20:48
Copy link
Member

@alancai98 alancai98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small typo and possible inclusion of a recent PR in the changelog. Otherwise the questions look good to me.

Co-authored-by: Alan Cai <caialan@amazon.com>
@am357 am357 merged commit 3527b0c into main Jun 28, 2022
@am357 am357 deleted the pr-template-update branch June 28, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants