Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sync] Let new subscribers know about already connected peers (backward-compatible) #7344

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

dmitry-markin
Copy link
Contributor

@dmitry-markin dmitry-markin commented Jan 27, 2025

Revert #7011 and replace it with a backward-compatible solution suitable for backporting to a release branch.

Review notes

It's easier to review this PR per commit: the first commit is just a revert, so it's enough to review only the second one, which is almost a one-liner.

@dmitry-markin dmitry-markin added the T0-node This PR/Issue is related to the topic “node”. label Jan 27, 2025
@dmitry-markin dmitry-markin self-assigned this Jan 27, 2025
@dmitry-markin
Copy link
Contributor Author

/cmd prdoc --bump patch --audience node_dev

@dmitry-markin dmitry-markin added the A4-needs-backport Pull request must be backported to all maintained releases. label Jan 27, 2025
@EgorPopelyaev EgorPopelyaev added this pull request to the merge queue Jan 27, 2025
Merged via the queue into master with commit ee30ec7 Jan 27, 2025
231 of 249 checks passed
@EgorPopelyaev EgorPopelyaev deleted the dm-initial-sync-peers branch January 27, 2025 13:11
@paritytech-cmd-bot-polkadot-sdk

Created backport PR for stable2407:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7344-to-stable2407
git worktree add --checkout .worktree/backport-7344-to-stable2407 backport-7344-to-stable2407
cd .worktree/backport-7344-to-stable2407
git reset --hard HEAD^
git cherry-pick -x ee30ec723ee22e247014217e48513a2e7690c953
git push --force-with-lease

@paritytech-cmd-bot-polkadot-sdk

Created backport PR for stable2409:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7344-to-stable2409
git worktree add --checkout .worktree/backport-7344-to-stable2409 backport-7344-to-stable2409
cd .worktree/backport-7344-to-stable2409
git reset --hard HEAD^
git cherry-pick -x ee30ec723ee22e247014217e48513a2e7690c953
git push --force-with-lease

github-actions bot pushed a commit that referenced this pull request Jan 27, 2025
…rd-compatible) (#7344)

Revert #7011 and replace
it with a backward-compatible solution suitable for backporting to a
release branch.

### Review notes
It's easier to review this PR per commit: the first commit is just a
revert, so it's enough to review only the second one, which is almost a
one-liner.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit ee30ec7)
@paritytech-cmd-bot-polkadot-sdk

Successfully created backport PR for stable2412:

EgorPopelyaev pushed a commit that referenced this pull request Jan 27, 2025
Backport #7344 into `stable2412` from dmitry-markin.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: Dmitry Markin <dmitry@markin.tech>
ordian added a commit that referenced this pull request Jan 30, 2025
* master: (58 commits)
  [pallet-revive] pack exceeding syscall arguments into registers (#7319)
  cumulus: bump PARENT_SEARCH_DEPTH and add test for 12-core elastic scaling (#6983)
  xcm: fix for DenyThenTry Barrier (#7169)
  Migrating polkadot-runtime-common slots benchmarking to v2 (#6614)
  Add development chain-spec file for minimal/parachain templates for Omni Node compatibility (#6529)
  `Arc` definition in `TransactionPool` (#7042)
  [sync] Let new subscribers know about already connected peers (backward-compatible) (#7344)
  Removed unused dependencies (partial progress) (#7329)
  Improve debugging by using `#[track_caller]` in system `assert_last_event` and `assert_has_event` (#7142)
  `set_validation_data` register weight manually, do not use refund when the pre dispatch is zero. (#7327)
  Fix the link to the chain snapshots (#7330)
  revive: Fix compilation of `uapi` crate when `unstable-hostfn` is not set (#7318)
  [pallet-revive] eth-rpc minor fixes (#7325)
  sync-templates: enable syncing from stable release patches (#7227)
  Bridges: emulated tests small nits/improvements (#7322)
  fix(cmd bench-omni): build omni-bencher with production profile (#7299)
  Nits for collectives-westend XCM benchmarks setup (#7215)
  bench all weekly - and fix for pallet_multisig lib (#6789)
  Deprecate ParaBackingState API (#6867)
  Fix setting the image properly (#7315)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A4-needs-backport Pull request must be backported to all maintained releases. T0-node This PR/Issue is related to the topic “node”.
Projects
Status: Blocked ⛔️
Development

Successfully merging this pull request may close these issues.

3 participants