Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nits for collectives-westend XCM benchmarks setup #7215

Merged
merged 13 commits into from
Jan 24, 2025
Merged

Nits for collectives-westend XCM benchmarks setup #7215

merged 13 commits into from
Jan 24, 2025

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Jan 17, 2025

Closes: #2904

@bkontur bkontur added R0-silent Changes should not be mentioned in any release notes T6-XCM This PR/Issue is related to XCM. T12-benchmarks This PR/Issue is related to benchmarking and weights. labels Jan 17, 2025
@bkontur
Copy link
Contributor Author

bkontur commented Jan 17, 2025

/cmd bench --pallet pallet_xcm pallet_xcm_benchmarks::fungible pallet_xcm_benchmarks::generic --runtime collectives-westend

@bkontur bkontur mentioned this pull request Jan 17, 2025
Closed
2 tasks
@github-actions GitHub Actions
Copy link
Contributor

Command "bench --pallet pallet_xcm pallet_xcm_benchmarks::fungible pallet_xcm_benchmarks::generic --runtime collectives-westend" has started 🚀 See logs here

@bkontur bkontur self-assigned this Jan 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

Command "bench --pallet pallet_xcm pallet_xcm_benchmarks::fungible pallet_xcm_benchmarks::generic --runtime collectives-westend" has failed ❌! See logs here

Command output:

✅ Successful benchmarks of runtimes/pallets:
-- collectives-westend: ['pallet_xcm', 'pallet_xcm_benchmarks::fungible', 'pallet_xcm_benchmarks::generic']

@github-actions GitHub Actions
Copy link
Contributor

Command "bench --pallet pallet_xcm pallet_xcm_benchmarks::fungible pallet_xcm_benchmarks::generic --runtime collectives-westend" has started 🚀 See logs here

Update from bkontur running command 'bench --pallet pallet_xcm pallet…
44b4ec2 
…_xcm_benchmarks::fungible pallet_xcm_benchmarks::generic --runtime collectives-westend'
@github-actions GitHub Actions
Copy link
Contributor

Command "bench --pallet pallet_xcm pallet_xcm_benchmarks::fungible pallet_xcm_benchmarks::generic --runtime collectives-westend" has finished ✅ See logs here

Subweight results:
File Extrinsic Old New Change [%]
cumulus/pallets/collator-selection/src/weights.rs leave_intent - - ERROR
cumulus/pallets/collator-selection/src/weights.rs new_session - - ERROR
cumulus/pallets/collator-selection/src/weights.rs register_as_candidate - - ERROR
cumulus/pallets/collator-selection/src/weights.rs set_invulnerables - - ERROR
cumulus/pallets/collator-selection/src/weights.rs take_candidate_slot - - ERROR
cumulus/pallets/collator-selection/src/weights.rs update_bond - - ERROR
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_preimage.rs ensure_updated - - ERROR
cumulus/parachains/runtimes/people/people-rococo/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/people/people-rococo/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/people/people-westend/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/people/people-westend/src/weights/pallet_collator_selection.rs update_bond - - ERROR
polkadot/runtime/westend/src/weights/pallet_preimage.rs ensure_updated - - ERROR
substrate/frame/election-provider-support/src/weights.rs phragmen - - ERROR
substrate/frame/election-provider-support/src/weights.rs phragmms - - ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs pay_fees 1.60us 128.81us +7930.74
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs expect_pallet 3.30us 5.54us +68.02
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs initiate_reserve_withdraw 380.35us 551.46us +44.99
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs report_transact_status 376.47us 545.54us +44.91
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs query_pallet 380.61us 551.38us +44.87
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs report_error 376.44us 545.25us +44.84
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs report_holding 380.36us 548.38us +44.18
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs receive_teleported_asset 2.45us 2.96us +20.92
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs clear_transact_status 659.00ns 734.00ns +11.38
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs expect_asset 739.00ns 806.00ns +9.07
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs transact 7.07us 7.69us +8.77
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs set_error_handler 645.00ns 699.00ns +8.37
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs expect_origin 651.00ns 700.00ns +7.53
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs unpaid_execution 655.00ns 702.00ns +7.18
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs clear_topic 634.00ns 678.00ns +6.94
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs transfer_reserve_asset 669.11us 715.47us +6.93
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs clear_origin 630.00ns 667.00ns +5.87
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs set_fees_mode 629.00ns 664.00ns +5.56
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs refund_surplus 1.35us 1.43us +5.54
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs descend_origin 688.00ns 726.00ns +5.52
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs expect_error 660.00ns 693.00ns +5.00
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs query_response 32.81us 31.14us -5.07
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_xcm.rs execute 38.57us 34.92us -9.48
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_xcm.rs migrate_and_notify_old_targets 748.38us 592.26us -20.86
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_xcm.rs force_subscribe_version_notify 737.85us 579.95us -21.40
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_xcm.rs teleport_assets 643.86us 495.76us -23.00
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs deposit_reserve_asset 534.60us 409.56us -23.39
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_xcm.rs transfer_assets 644.52us 485.90us -24.61
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_xcm.rs force_unsubscribe_version_notify 614.84us 456.83us -25.70
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs subscribe_version 474.29us 349.75us -26.26
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_xcm.rs notify_current_targets 534.74us 378.87us -29.15
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs initiate_teleport 379.02us 263.10us -30.58
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_xcm.rs send 408.42us 252.78us -38.11
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_xcm.rs force_default_xcm_version 102.47us 2.54us -97.53
Command output:

✅ Successful benchmarks of runtimes/pallets:
-- collectives-westend: ['pallet_xcm', 'pallet_xcm_benchmarks::fungible', 'pallet_xcm_benchmarks::generic']

@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12829223224
Failed job name: check-runtime-migration

@bkontur
Copy link
Contributor Author

bkontur commented Jan 22, 2025

/cmd bench --pallet pallet_xcm_benchmarks::generic --runtime collectives-westend

@github-actions GitHub Actions
Copy link
Contributor

Command "bench --pallet pallet_xcm_benchmarks::generic --runtime collectives-westend" has started 🚀 See logs here

@github-actions GitHub Actions
Copy link
Contributor

Command "bench --pallet pallet_xcm_benchmarks::generic --runtime collectives-westend" has failed ❌! See logs here

Command output:

✅ Successful benchmarks of runtimes/pallets:
-- collectives-westend: ['pallet_xcm_benchmarks::generic']

@github-actions GitHub Actions
Copy link
Contributor

Command "bench --pallet pallet_xcm_benchmarks::generic --runtime collectives-westend" has started 🚀 See logs here

Update from bkontur running command 'bench --pallet pallet_xcm_benchm…
0cdfc3a 
…arks::generic --runtime collectives-westend'
@github-actions GitHub Actions
Copy link
Contributor

Command "bench --pallet pallet_xcm_benchmarks::generic --runtime collectives-westend" has finished ✅ See logs here

Subweight results:
File Extrinsic Old New Change [%]
cumulus/pallets/collator-selection/src/weights.rs leave_intent - - ERROR
cumulus/pallets/collator-selection/src/weights.rs new_session - - ERROR
cumulus/pallets/collator-selection/src/weights.rs register_as_candidate - - ERROR
cumulus/pallets/collator-selection/src/weights.rs set_invulnerables - - ERROR
cumulus/pallets/collator-selection/src/weights.rs take_candidate_slot - - ERROR
cumulus/pallets/collator-selection/src/weights.rs update_bond - - ERROR
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_preimage.rs ensure_updated - - ERROR
cumulus/parachains/runtimes/people/people-rococo/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/people/people-rococo/src/weights/pallet_collator_selection.rs update_bond - - ERROR
cumulus/parachains/runtimes/people/people-westend/src/weights/pallet_collator_selection.rs take_candidate_slot - - ERROR
cumulus/parachains/runtimes/people/people-westend/src/weights/pallet_collator_selection.rs update_bond - - ERROR
polkadot/runtime/westend/src/weights/pallet_preimage.rs ensure_updated - - ERROR
substrate/frame/election-provider-support/src/weights.rs phragmen - - ERROR
substrate/frame/election-provider-support/src/weights.rs phragmms - - ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs pay_fees 1.60us 128.84us +7932.61
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs expect_pallet 3.30us 5.72us +73.57
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs query_pallet 380.61us 554.27us +45.62
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs report_transact_status 376.47us 546.14us +45.07
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs initiate_reserve_withdraw 380.35us 551.46us +44.99
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs report_error 376.44us 545.04us +44.79
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs report_holding 380.36us 549.96us +44.59
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs receive_teleported_asset 2.45us 2.96us +20.92
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs transact 7.07us 7.82us +10.61
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs transfer_reserve_asset 669.11us 715.47us +6.93
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs expect_asset 739.00ns 785.00ns +6.22
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_xcm.rs execute 38.57us 34.92us -9.48
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_xcm.rs migrate_and_notify_old_targets 748.38us 592.26us -20.86
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_xcm.rs force_subscribe_version_notify 737.85us 579.95us -21.40
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_xcm.rs teleport_assets 643.86us 495.76us -23.00
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs deposit_reserve_asset 534.60us 409.56us -23.39
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_xcm.rs transfer_assets 644.52us 485.90us -24.61
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_xcm.rs force_unsubscribe_version_notify 614.84us 456.83us -25.70
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs subscribe_version 474.29us 350.20us -26.16
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_xcm.rs notify_current_targets 534.74us 378.87us -29.15
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs initiate_teleport 379.02us 263.10us -30.58
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_xcm.rs send 408.42us 252.78us -38.11
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs alias_origin 2.00us 676.00ns -66.20
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_xcm.rs force_default_xcm_version 102.47us 2.54us -97.53
Command output:

✅ Successful benchmarks of runtimes/pallets:
-- collectives-westend: ['pallet_xcm_benchmarks::generic']

@bkontur bkontur added this pull request to the merge queue Jan 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 23, 2025
@bkontur bkontur added this pull request to the merge queue Jan 24, 2025
Merged via the queue into master with commit 2360007 Jan 24, 2025
203 of 206 checks passed
@bkontur bkontur deleted the bko-collectives-benchmarks branch January 24, 2025 13:04
ordian added a commit that referenced this pull request Jan 30, 2025
@ordian
Merge branch 'master' into ao-migrate-zombie-past-slashing-test
722a770 
* master: (58 commits)
  [pallet-revive] pack exceeding syscall arguments into registers (#7319)
  cumulus: bump PARENT_SEARCH_DEPTH and add test for 12-core elastic scaling (#6983)
  xcm: fix for DenyThenTry Barrier (#7169)
  Migrating polkadot-runtime-common slots benchmarking to v2 (#6614)
  Add development chain-spec file for minimal/parachain templates for Omni Node compatibility (#6529)
  `Arc` definition in `TransactionPool` (#7042)
  [sync] Let new subscribers know about already connected peers (backward-compatible) (#7344)
  Removed unused dependencies (partial progress) (#7329)
  Improve debugging by using `#[track_caller]` in system `assert_last_event` and `assert_has_event` (#7142)
  `set_validation_data` register weight manually, do not use refund when the pre dispatch is zero. (#7327)
  Fix the link to the chain snapshots (#7330)
  revive: Fix compilation of `uapi` crate when `unstable-hostfn` is not set (#7318)
  [pallet-revive] eth-rpc minor fixes (#7325)
  sync-templates: enable syncing from stable release patches (#7227)
  Bridges: emulated tests small nits/improvements (#7322)
  fix(cmd bench-omni): build omni-bencher with production profile (#7299)
  Nits for collectives-westend XCM benchmarks setup (#7215)
  bench all weekly - and fix for pallet_multisig lib (#6789)
  Deprecate ParaBackingState API (#6867)
  Fix setting the image properly (#7315)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes

@acatangiu acatangiu acatangiu approved these changes

Assignees

@bkontur bkontur

Labels
R0-silent Changes should not be mentioned in any release notes T6-XCM This PR/Issue is related to XCM. T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
Bridges + XCM
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[collectives-westend] Setup xcm benchmarked weights instead of FixedWeightBounds
3 participants
@bkontur @franciscoaguirre @acatangiu