Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ParaBackingState API #6867

Merged
merged 20 commits into from
Jan 23, 2025
Merged

Deprecate ParaBackingState API #6867

merged 20 commits into from
Jan 23, 2025

Conversation

sandreim
Copy link
Contributor

@sandreim sandreim commented Dec 13, 2024 •
edited
Loading

Currently the para_backing_state API is used only by the prospective parachains subsystems and returns 2 things: the constraints for parachain blocks and the candidates pending availability.

This PR deprecates para_backing_state and introduces a new backing_constraints API that can be used together with candidates_pending_availability to get the same information provided by para_backing_state.

TODO:

  • PRDoc

@sandreim
Add new constraints primitive and runtime API
a583810 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
prospective parachains: use new runtime API
56e74ef 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
tests
b9de739 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
alindima
alindima reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@alindima alindima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

cumulus/client/relay-chain-minimal-node/src/blockchain_rpc_client.rs Outdated Show resolved Hide resolved
polkadot/node/subsystem-util/src/inclusion_emulator/mod.rs Show resolved Hide resolved
polkadot/primitives/src/runtime_api.rs Outdated Show resolved Hide resolved
polkadot/runtime/parachains/src/runtime_api_impl/vstaging.rs Outdated Show resolved Hide resolved
polkadot/node/core/prospective-parachains/src/lib.rs Outdated Show resolved Hide resolved
polkadot/node/core/prospective-parachains/src/tests.rs Show resolved Hide resolved
@sandreim
implement review feedback
9cabe86 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Merge branch 'sandreim/refactor_constraints' of github.com:paritytech…
f459c42 
…/polkadot-sdk into sandreim/refactor_constraints
@sandreim
rename
1877d44 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim marked this pull request as ready for review January 16, 2025 15:28
@sandreim
Copy link
Contributor Author

bot fmt

@command-bot
Copy link

command-bot bot commented Jan 17, 2025 •
edited
Loading

@sandreim https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8047468 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 14-ddf68191-da65-4ae1-ad64-e2793f834a77 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jan 17, 2025

@sandreim Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8047468 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8047468/artifacts/download.

@sandreim
remove print
aefd1ec 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Merge branch 'sandreim/refactor_constraints' of github.com:paritytech…
a096e81 
…/polkadot-sdk into sandreim/refactor_constraints
@sandreim
fix build
5f33c41 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix tests
1279a75 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
happy clippy
93fc80f 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
ordian
ordian approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable modulo some failing CI checks

@sandreim
clippy still unhappy
fec47ec 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Merge branch 'master' of github.com:paritytech/polkadot-sdk into sand…
863b049 
…reim/refactor_constraints
@sandreim
Copy link
Contributor Author

/cmd prdoc --bump minor --audience node_operator

command-bot and others added 2 commits January 21, 2025 16:15
Update from sandreim running command 'prdoc --bump minor --audience n…
4b9b3cf 
…ode_operator'
@sandreim
update generated PRDoc
be8d32b 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim added T0-node This PR/Issue is related to the topic “node”. T4-runtime_API This PR/Issue is related to runtime APIs. labels Jan 22, 2025
@sandreim sandreim added the T8-polkadot This PR/Issue is related to/affects the Polkadot network. label Jan 22, 2025
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12909108580
Failed job name: test-linux-stable

@sandreim
Merge branch 'master' of github.com:paritytech/polkadot-sdk into sand…
fc9a1f0 
…reim/refactor_constraints
@sandreim
adjust semver
efb8e56 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim added this pull request to the merge queue Jan 23, 2025
Merged via the queue into master with commit e9393a9 Jan 23, 2025
199 of 204 checks passed
@sandreim sandreim deleted the sandreim/refactor_constraints branch January 23, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexggh alexggh alexggh left review comments

@alindima alindima alindima approved these changes

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
T0-node This PR/Issue is related to the topic “node”. T4-runtime_API This PR/Issue is related to runtime APIs. T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sandreim @ordian @alindima @alexggh