Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use meseeksdev for backporting #21070

Closed
TomAugspurger opened this issue May 16, 2018 · 19 comments
Closed

Use meseeksdev for backporting #21070

TomAugspurger opened this issue May 16, 2018 · 19 comments

Comments

@TomAugspurger
Copy link
Contributor

cc @jreback @jorisvandenbossche OK by you? Enable at https://github.com/apps/meeseeksdev/installations/new

I think @Carreau whitelisted the pandas org.

@jorisvandenbossche
Copy link
Member

Just to understand the workflow here that would be used: Meeseeks will open a new PR for each PR that we tag for the bugfix release? (in constrast with the bulk cherry-picking that we now did more manually)

That gives some more traffic on github .. but on the other hand is also more transparent.

Anyhow, it's good to look at way to automate this more!

@Carreau
Copy link
Contributor

Carreau commented May 16, 2018

So far it is based on milestone.
You edit your milestone description with commands to be executed on merge.

For example IPython 5.7 milestone contains:

on-merge: backport to 5.x
on-merge: backport to 6.x

So for example when ipython/ipython#11043 was merged in master, the PR ipython/ipython#11046 was automatically open.

If the bot can't cherry pick, it complains on the PR and tag it with "Still needs manual backport". for example : ipython/ipython#10707 (comment)

You could of course add

on-merge: say "Oweeeee"

Or any other command you like the bot understand. (tag, untag, say, ... )

You can also mention the bot and ask it to do things. If you have commit right on the repo (and the bot is enabled), the bot will respond.

It push the backported branch on the same repository, because of some GitHub limitation as you can't make cross-repo PRs with integrations tokens. I have plan to fix that by creating a machine-account, and juggling with tokens, but so far haven't found the time to do it.

Does that clarify things ?

@Carreau
Copy link
Contributor

Carreau commented May 22, 2018

It push the backported branch on the same repository, because of some GitHub limitation as you can't make cross-repo PRs with integrations tokens. I have plan to fix that by creating a machine-account, and juggling with tokens, but so far haven't found the time to do it.

I've now implemented (in beta) the ability to backport without requiring push permissions. See scientific-python/MeeseeksDev#28

I'll switch the default mechanism after some testing, and then remove the request for push access.

@jorisvandenbossche
Copy link
Member

@Carreau thanks for the explanation!

An additional question: it is also possible to have a command to say to the bot to still backport a PR once it is already merged? (eg in case you forgot to label it or only decide afterwards to still target it for that release, or now in our case because the bot was not yet enabled)

@TomAugspurger
Copy link
Contributor Author

Should be @MeeseeksDev backport to 0.23.x.

@jorisvandenbossche
Copy link
Member

Ideally I would like to have something that does backports in batches to avoid many PRs, but if this improves the workflow, let's go for it :)

@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Jun 7, 2018 via email

@Carreau
Copy link
Contributor

Carreau commented Jun 7, 2018

Ideally I would like to have something that does backports in batches to avoid many PRs, but if this improves the workflow, let's go for it :)

If you want to have something that avoids PRs and push directly to stables branches it is feasible. We just need to modify the command to directly push. Which should not be too hard.

@TomAugspurger
Copy link
Contributor Author

@meeseeksdev Hello

@Carreau
Copy link
Contributor

Carreau commented Jun 12, 2018

Hum... it may be case sensitive. Try lowercase ?

@jorisvandenbossche
Copy link
Member

@meeseeksdev hello

@TomAugspurger
Copy link
Contributor Author

FWIW, I think I requested permission for pandas-dev/pandas a couple days ago. Not sure if it went through.

@Carreau
Copy link
Contributor

Carreau commented Jun 12, 2018

Hum, it did not receive any events from GitHub. Is it correctly activated ? I restarted the bot just in case.

@TomAugspurger
Copy link
Contributor Author

Seems like it's still staging.

screen shot 2018-06-12 at 9 14 49 am

@Carreau
Copy link
Contributor

Carreau commented Jun 12, 2018

Hum, that's not from my end, I should not have to validate any of these.

@Carreau
Copy link
Contributor

Carreau commented Jun 12, 2018

An admin of the org maybe ?

@TomAugspurger
Copy link
Contributor Author

@meeseeksdev Hello

@lumberbot-app
Copy link

lumberbot-app bot commented Jul 5, 2018

I'm Mr. Meeseek, @TomAugspurger, Look at meee !

@mroeschke
Copy link
Member

Looks like we've enabled this. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants