-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use meseeksdev for backporting #21070
Comments
Just to understand the workflow here that would be used: Meeseeks will open a new PR for each PR that we tag for the bugfix release? (in constrast with the bulk cherry-picking that we now did more manually) That gives some more traffic on github .. but on the other hand is also more transparent. Anyhow, it's good to look at way to automate this more! |
So far it is based on milestone. For example IPython 5.7 milestone contains:
So for example when ipython/ipython#11043 was merged in master, the PR ipython/ipython#11046 was automatically open. If the bot can't cherry pick, it complains on the PR and tag it with "Still needs manual backport". for example : ipython/ipython#10707 (comment) You could of course add
Or any other command you like the bot understand. (tag, untag, say, ... ) You can also mention the bot and ask it to do things. If you have commit right on the repo (and the bot is enabled), the bot will respond. It push the backported branch on the same repository, because of some GitHub limitation as you can't make cross-repo PRs with integrations tokens. I have plan to fix that by creating a machine-account, and juggling with tokens, but so far haven't found the time to do it. Does that clarify things ? |
I've now implemented (in beta) the ability to backport without requiring push permissions. See scientific-python/MeeseeksDev#28 I'll switch the default mechanism after some testing, and then remove the request for push access. |
@Carreau thanks for the explanation! An additional question: it is also possible to have a command to say to the bot to still backport a PR once it is already merged? (eg in case you forgot to label it or only decide afterwards to still target it for that release, or now in our case because the bot was not yet enabled) |
Should be |
Ideally I would like to have something that does backports in batches to avoid many PRs, but if this improves the workflow, let's go for it :) |
I think I can manually backport this first batch, and then we'll start
using the bot for new ones.
…On Thu, Jun 7, 2018 at 8:38 AM, Joris Van den Bossche < ***@***.***> wrote:
Ideally I would like to have something that does backports in batches to
avoid many PRs, but if this improves the workflow, let's go for it :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#21070 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIkIIiTKvpY4UxVKOTvTFKIwUGmXMks5t6SzLgaJpZM4UAjxW>
.
|
If you want to have something that avoids PRs and push directly to stables branches it is feasible. We just need to modify the command to directly push. Which should not be too hard. |
@meeseeksdev Hello |
Hum... it may be case sensitive. Try lowercase ? |
@meeseeksdev hello |
FWIW, I think I requested permission for pandas-dev/pandas a couple days ago. Not sure if it went through. |
Hum, it did not receive any events from GitHub. Is it correctly activated ? I restarted the bot just in case. |
Hum, that's not from my end, I should not have to validate any of these. |
An admin of the org maybe ? |
@meeseeksdev Hello |
I'm Mr. Meeseek, @TomAugspurger, Look at meee ! |
Looks like we've enabled this. Closing |
cc @jreback @jorisvandenbossche OK by you? Enable at https://github.com/apps/meeseeksdev/installations/new
I think @Carreau whitelisted the pandas org.
The text was updated successfully, but these errors were encountered: