Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport without requiring push permission. #28

Closed
Carreau opened this issue May 22, 2018 · 4 comments
Closed

Backport without requiring push permission. #28

Carreau opened this issue May 22, 2018 · 4 comments

Comments

@Carreau
Copy link
Contributor

Carreau commented May 22, 2018

I want to upgrade Mr. Meeseeks to not require push-permissions to repositories for many reason:

  1. Security
  2. not clutter repos with branches named backport-pr-XXX-to-YYYY.

Thus I've created a meeseeksmachine GitHub Machine account it's like a personal account but have no human activity. With the creds of this account, I can fork, and make cross-organisation PRs, which Mr Meeseks couldn't do before due to GitHub limitation..

Using the new safe_backport, Mr Meeseeks can now backport without touching the target repository. The backport PR is created by, and come from the @meeseeksmachine account, like in this PR, @meeseeksdev is still responsible for the rest.

if you want to try it now

Change backport to safe_backport and report any potential bugs.

In the future I'll switch the backport to use the new mechanism, and remove the requirement for push permission.

@Carreau
Copy link
Contributor Author

Carreau commented May 22, 2018

One of the other advantage is that pushing on same-repo was also putting pressure on CI, as both push and PR would trigger it.

@Carreau
Copy link
Contributor Author

Carreau commented Jul 18, 2018

I've switched the default. You can use legacy_backport if there are issues.

@QuLogic
Copy link
Collaborator

QuLogic commented Aug 19, 2018

It seems like this still creates the branch on the original repo even though the PR is opened from the @meeseeksmachine account?

@Carreau
Copy link
Contributor Author

Carreau commented Aug 19, 2018

Hum it appears you are right. I just completely removed the old backport code (including removeing legacy_backport, and pushed a fix. The bot has been restarted so this should not hapend anymore.

@Carreau Carreau closed this as completed Sep 21, 2018
Carreau added a commit that referenced this issue Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants