RLS: 0.23.1

[TomAugspurger]

cc @pandas-dev/pandas-core

Targeting Friday June 8th.

[jorisvandenbossche]

@TomAugspurger Do you have time to do the backporting one of the coming days?

[TomAugspurger]

Some, but not much... Any objections to enable the backport bot? https://github.com/integration/meeseeksdev/

[jreback]

looks ok to me
how do u use?

[TomAugspurger]

#21070 (comment) Basically update the 0.23.1 tag to have the description "on-merge: backport to 0.23.x" We may need to manually backport things that have already been merged.

…

On Thu, Jun 7, 2018 at 6:47 AM, Jeff Reback ***@***.***> wrote: looks ok to me how do u use? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#21312 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIhwjb0yFOYFTHWSZek57_LKVl55Bks5t6RLmgaJpZM4UY_QL> .

[TomAugspurger]

How are we looking for 0.23.1 sometime soon (today?)

• Warn on duplicate names in MI? #19029 is open (duplicate names in the MI).
• CI: NumPy logical reductions (any, all) fail on DataFrame with NumPy master #19976 (comment) update on np.all(df) failures. I have the logical reductions working properly again, but that's a partial solution.

[jreback]

#19029 needs some work and is not blocking here

[toobaz]

Thoughts on #21313 (which now also fixes #21428 )?

[TomAugspurger]

#21313 looks a bit "big", but I'm not familiar with the indexing code :)

@jorisvandenbossche OK with pushing #21423 / #19029 to 0.23.2? Or should it block?

#19535 might be nice to include, since we've had a couple people report issues trying to install the sdist. That'll fix it, but the smaller fix is to just fix this manifest.

[jorisvandenbossche]

Yes, #21313 is for 0.24.0 I think.

OK with pushing #21423 / #19029 to 0.23.2? Or should it block?

I personally think it is a small and easy change, but not many people reacted the last days on the issue ..

Do you have something for #19976

I would maybe rather release just now, and do a relative quick next 0.23.2 release.

[TomAugspurger]

Agreed with a short timeline for 0.23.2, maybe end of June.

[TomAugspurger]

Going to do the rest of the backports for 0.23.1 now.

[TomAugspurger]

#21442 should have the remaining backports.

0.23.1 will then be frozen and I'll do the release.

[TomAugspurger]

Backports done. Tagging.

[TomAugspurger]

Tagged and updated docs / website.

Waiting on binary builds.

[cgohlke]

How do I test the installed pandas package? I get 100% test errors on Windows using python -m pytest --pyargs pandas:

============================= test session starts =============================
platform win32 -- Python 3.6.5, pytest-3.6.1, py-1.5.3, pluggy-0.6.0
rootdir: C:\Users\...\test, inifile:
plugins: xdist-1.22.2, pep8-1.0.6, forked-0.2, faulthandler-1.5.0, cov-2.5.1, palladium-1.1.0.1, hypothesis-3.57.0, celery-4.1.1
collected 26384 items / 2 skipped

pandas\tests\test_algos.py EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE [  0%]
EEEE

=================================== ERRORS ====================================
____________________ ERROR at setup of TestMatch.test_ints ____________________

self = <_pytest.config.Config object at 0x0000028177D2F4E0>, name = 'only_slow'
default = <NOTSET>, skip = False

    def getoption(self, name, default=notset, skip=False):
        """ return command line option value.

            :arg name: name of the option.  You may also specify
                the literal ``--OPT`` option instead of the "dest" option name.
            :arg default: default value if no option of that name exists.
            :arg skip: if True raise pytest.skip if option does not exists
                or has a None value.
            """
        name = self._opt2dest.get(name, name)
        try:
>           val = getattr(self.option, name)
E           AttributeError: 'Namespace' object has no attribute 'only_slow'

X:\Python36\lib\site-packages\_pytest\config.py:1254: AttributeError

During handling of the above exception, another exception occurred:

item = <Function 'test_ints'>

    def pytest_runtest_setup(item):
        if 'slow' in item.keywords and item.config.getoption("--skip-slow"):
            pytest.skip("skipping due to --skip-slow")

>       if 'slow' not in item.keywords and item.config.getoption("--only-slow"):
E       ValueError: no option named 'only_slow'

X:\Python36\lib\site-packages\pandas\conftest.py:24: ValueError
<snip>

[TomAugspurger]

Does python -c "import pandas; pandas.test()" work?

[cgohlke]

Does python -c "import pandas; pandas.test()" work?

Yes, it does. Sorry, I get confused with the many ways to invoke tests...

[TomAugspurger]

:) pandas is probably doing something wrong with our conftest here :)

[TomAugspurger]

All done.