Drawio improvements

[diocas]

A couple of improvements to Drawio:

• Honor the autosave configuration, and actually save
• Show error messages to the user, currently all failures are silent
• Enable opening from public links without being authenticated

Let me know if this strategy for public links is ok. I was thinking of applying the same logic into the app provider/external app, as this is also not working properly with public links.
Maybe the mixin fileAcess that I created here can be moved somewhere else and re-used? Where do you suggest? web-pkg?

[diocas]

Should I fix the issue reported by sonar? I can add this.config.url to the post message (although, if there are services that redirect to a diff url this is no longer valid...)

[dschmidt]

I like that you extracted the private/public link handling and I agree it should be moved out of this app.

@pascalwengerter @kulmann I've added this to the Web Fastlane as I need this kind of file handling for fixing other bugs with other apps. We should discuss what a proper place would be for this functionality and loader mixin of media-viewer - be it a mixin, a service or whatever.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
1 Vulnerability
0 Security Hotspots
2 Code Smells

No Coverage information
No Duplication information

[dschmidt]

Hey @diocas

#6156 has been merged. Would you mind rebasing your PR?

You could refer to the media-viewer app how to use the composable or look at my commits in #6134

Thanks! Let me know if I can support you in any way 😇

[dschmidt]

Oopsie, I forgot I had applied it to draw.io already - so basically you just need to remove your file handling changes and need to make sure all other changes apply cleanly. Hope it's straight forward :)

[kulmann]

Thanks @dschmidt - one addition: draw-io now has the :contextRouteName in the route as well, which allows us to determine if the user came from a public link or from an authenticated context. With this, the route duplication is not needed anymore.

[diocas]

Et voilà @dschmidt @kulmann !
Do you mind doing one last test? I'm trying but my ocis setup is broken and I still trying to understand what is going on...

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
1 Vulnerability
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[ownclouders]

Results for oC10SharingExternal https://drone.owncloud.com/owncloud/web/22078/40/1
The following scenarios passed on retry:

• webUISharingExternal/federationSharing.feature:106

[diocas]

Looks like that with the latest changes, drawio no longer takes the configurations and just uses the default values.
edit: #6296

[dschmidt]

We should maybe not leak any internal error message to the user, but we can fix that in a follow up PR imho.

[kulmann]

I agree with both statements 😅

[kulmann]

I agree with both statements 😅