Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration unavailable within extensions #6296

Closed
diocas opened this issue Jan 21, 2022 · 1 comment · Fixed by #6298
Closed

Configuration unavailable within extensions #6296

diocas opened this issue Jan 21, 2022 · 1 comment · Fixed by #6298
Assignees
Labels
Early-Adopter:CERN Type:Bug Something isn't working

Comments

@diocas
Copy link
Contributor

diocas commented Jan 21, 2022

Web is loading the configs before registering the apps (which populates state.fileEditors). This means that the following code has no effect:

  LOAD_EXTENSION_CONFIG(state, { id, config }) {
    // make available in editors
    const editors = [...state.fileEditors]
    for (const editor of editors) {
      if (editor.app === id) {
        editor.config = config
      }
    }
    state.fileEditors = editors
(...)

(https://github.com/owncloud/web/blob/master/packages/web-runtime/src/store/apps.js#L109)

Without this, there are no configurations available within the extension context.

@dschmidt
Copy link
Member

Thanks for debugging!

@dschmidt dschmidt self-assigned this Jan 21, 2022
dschmidt added a commit that referenced this issue Jan 22, 2022
Fix #6296: Make app config available to app again
@kulmann kulmann moved this to Done in Web Support Board Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Early-Adopter:CERN Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants