Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6296: Make app config available to app again #6298

Merged
merged 1 commit into from
Jan 22, 2022
Merged

Conversation

dschmidt
Copy link
Member

Description

Related Issue

Motivation and Context

The config is loaded before the actual app, so when the old code tried to persist the setting inside the application object inside the store it was not available. That's why we now cache the config and copy it into the app object, once it becomes available. This should be a true drop in change and I don't expect any side effects as we did not change the internal structure of the object in the store.

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jan 21, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch ❤️ 🤖

@dschmidt
Copy link
Member Author

kudos to @diocas for finding the issue :)

@dschmidt dschmidt merged commit c437e73 into master Jan 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix_app_config branch January 22, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration unavailable within extensions
2 participants