Fix #6296: Make app config available to app again #6298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
The config is loaded before the actual app, so when the old code tried to persist the setting inside the application object inside the store it was not available. That's why we now cache the config and copy it into the app object, once it becomes available. This should be a true drop in change and I don't expect any side effects as we did not change the internal structure of the object in the store.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: