Ensure route config is honored for new file handlers #6135
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
I'm not sure why these smoke tests are failing.. Any pointer? |
Could you rebase? We reduced the flakiness by a bit yesterday, still some OC10 issues remaining, sadly. Context lives in #6082 (comment) |
|
@pascalwengerter I was following that ticket and rebased today. There's still the possibility I broke something... I made an assumption that maybe it's not correct. |
The changes don't look related to the failures in CI. Let's wait for #6149 to be merged and rebase your PR and see :) |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@pascalwengerter all green now :) |
If we have more than one new file handler in the extensions, we never check the routes associated with them.
If, for example, we need different routes in order to distinguish internal and public links (i.e #6125), without this fix we would see both entries in the "new" menu.
In the past I only added a single "new handler" to avoid seeing 2 entries, but then when I create a new file, the opening action will match the route it belongs to.