Add emitting of hook post_unshareFromSelf to Share 2.0 #28401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This hook used to be present in Share 1.0 but was missing from 2.0 - Some new key-value pairs have been added to the hook parameter data as compared to 1.0. This is to make the hook more useful and to enable unified handling of the hooks post_unshare and post_unshareFromSelf. - Fixes owncloud#28337
|
|
paulijar
added a commit
to paulijar/music
that referenced
this pull request
Jul 14, 2017
- This solves owncloud#567 together with the core PR owncloud/core#28401
paulijar
added a commit
to paulijar/music
that referenced
this pull request
Jul 16, 2017
- This solves owncloud#567 together with the core PR owncloud/core#28401
PVince81
reviewed
Jul 17, 2017
| 'itemSource' => $share->getNodeId(), | ||
| 'shareType' => $shareType, | ||
| 'shareWith' => $sharedWith, | ||
| 'itemparent' => method_exists($share, 'getParent') ? $share->getParent() : '', |
There was a problem hiding this comment.
did you find any scenario where the share doesn't have the method getParent ??
There was a problem hiding this comment.
ah, you just moved the old code. ok
|
@paulijar can you backport this to stable10 and stable9.1 ? Basically resubmit a PR for stable10 and another one with stable9.1 with the same commits. |
This was referenced Jul 17, 2017
|
@PVince81 Sure, done. |
13 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Emit the hook signal
post_unshareFromSelfwhen the recipient of a share unshares it. This signal used to be present in Share 1.0 but was missing from 2.0. Share 2.0 sent a signal (post_unshare) only in case the usharing was done by the file owner.Some new key-value pairs are added to the hook parameter data as compared to 1.0. This is to make the hook more useful and to enable unified handling of the hooks
post_unshareandpost_unshareFromSelf.Related Issue
#28337
Motivation and Context
There must be a way for applications to detect when a file or folder becomes unavailable. The missing signal emission is regression as compared to Share 1.0.
The parameter data of the
post_unshareFromSelfsignal was augmented as compared to Share 1.0. The motivation for this was to make the data more similar with the other signalpost_unshareand to make the signal more useful: with the parameter content of Share 1.0, it was impossible to obtain the node ID of the unshared file/folder.How Has This Been Tested?
Tested on top of ownCloud 9.1.3. Connected the hooks
post_unshareandpost_unshareFromSelfin application code and added debug logging to the connected hook functions. Tested user shares and group shares, and unshared them both from the file owner and the share recipient, and checked in each case from the log that the hooks had fired and the parameter data was as expected.Types of changes
Checklist: