-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dispatcher event for audit log #28611
Conversation
Adding a dispatcher event to log unshare event done by the recipient. Signed-off-by: Sujith H <sharidasan@owncloud.com>
@@ -870,6 +870,13 @@ public function deleteFromSelf(\OCP\Share\IShare $share, $recipientId) { | |||
$hookParams['itemTarget'] = $hookParams['fileTarget']; | |||
$hookParams['unsharedItems'] = [$hookParams]; | |||
\OC_Hook::emit('OCP\Share', 'post_unshareFromSelf', $hookParams); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grep-ing through the source, I couldn't find connect for post_unshareFromSelf
being used. One more reference is found in the core https://github.com/owncloud/core/blob/master/lib/private/Share/Share.php#L1101 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because it was missing and just got added recently in #28401
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Backport stable10: #29851 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Adding a dispatcher event to log unshare
event done by the recipient.
Signed-off-by: Sujith H sharidasan@owncloud.com
Description
This change helps to dispatch the unshare event triggered by recipient user.
Related Issue
Motivation and Context
This helps to trigger unshare event triggered by recipient user.
How Has This Been Tested?
test
and filesampletext.txt
under user admintest
andsampletext.txt
to useruser1
user1
unsharetest
folder and filesampletext.txt
Below are the logs obtained:
Screenshots (if appropriate):
Types of changes
Checklist: