Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable9.1] Add emitting of hook post_unshareFromSelf to Share 2.0 #28412

Merged

Conversation

paulijar
Copy link
Contributor

Backport #28401 to stable 9.1

- This hook used to be present in Share 1.0 but was missing from 2.0
- Some new key-value pairs have been added to the hook parameter data as compared to 1.0. This is to make the hook more useful and to enable unified handling of the hooks post_unshare and post_unshareFromSelf.
- Fixes owncloud#28337

(cherry picked from commit 9a385ab)
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@paulijar did you retest this with your app ?

@paulijar
Copy link
Contributor Author

@PVince81 I retested on top of ownCloud 9.1.3 by copying the whole Share20 library from the branch stable9.1-share20-post_unshareFromSelf, and it still works. The stable10 branch I haven't tested, but I'm pretty confident that it works the same.

@PVince81 PVince81 merged commit 3be5656 into owncloud:stable9.1 Jul 17, 2017
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants