-
-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: empty reward bags should disappear after closing/opening reward chest #779
Closed
ElimarCosta
wants to merge
40
commits into
opentibiabr:main
from
ElimarCosta:bug-empty-rewards-should-disappear
Closed
fix: empty reward bags should disappear after closing/opening reward chest #779
ElimarCosta
wants to merge
40
commits into
opentibiabr:main
from
ElimarCosta:bug-empty-rewards-should-disappear
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
288f512
to
c1c85a1
Compare
This was
linked to
issues
Jan 15, 2023
c1c85a1
to
90135dd
Compare
…om/ElimarCosta/canary into bug-empty-rewards-should-disappear
o pull ta funcionando mais apos certo tempo comecei a ter esse crash mais não entendi ainda como ele ocorre no lado do bau de recompensa |
Sim, essa pr ta com alguns problemas ainda, tem varios bugs relacionados e eu to sem tempo essa semana por isso marquei como draft. |
Kudos, SonarCloud Quality Gate passed! |
bdb1fba
to
438ebf2
Compare
This was
linked to
issues
Jan 27, 2023
Closed
…pentibiabr#827) This brings in a major overhaul of the Item Attributes component, addressing long-standing issues in the TFS and OpenTibiaServer project. Adopting class inheritance and harnessing the latest capabilities of C++, this update resolves specific crashes and streamlines future changes to the code. The Attributes class has been separated into its own file, making the code more readable and easier to understand, while also removing any confusing and redundant functions from the Item class. This results in a more stable, maintainable, and user-friendly solution for Item Attributes. Simplified code by moving to shared_ptr for memory management, removing redundant functions, and revamping key classes such as Attributes, ItemAttribute, and CustomAttribute. The deprecated "set/getSpecialAttribute" functions have been replaced with more efficient "set/getCustomAttribute." This simplified approach leads to better code maintenance and increased stability, for example, Hirelings now utilize the CustomAttribute.
opentibiabr#841) The issue arose because the multi-floor was not properly verified, causing incorrect identification of some creatures.
…r#773) This change adds the new outfit and mount preview feature in the Tibia game store. In addition to the new interface, which offers a better structured and layout, players can now try out all the available outfits and mounts before purchasing them.
In the opentibiabr/otservbr-global#781 fixing the `The New Frontier Quest`, mistakenly replaced Ongulf's script with Leeland's script. Reverting to the correct script.
…om/ElimarCosta/canary into bug-empty-rewards-should-disappear
Kudos, SonarCloud Quality Gate passed! |
1 task
moved to #846 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Behaviour
Actual
You need to log out/in to remove empty reward bags
There was a limit of 100 rewards after that the system behaved strangely
When 'n' bosses were killed at the same second it would create only one reward bag for 'n' bosses
Expected
Empty reward bags should disappear after closing/opening
Shouldn't have limit for rewards
Each boss should have his reward bag
Type of change