Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stacking Reward Bags (100+) make then unable to be opened #157

Closed
1 task done
Zapotoczny opened this issue Nov 2, 2021 · 2 comments · Fixed by #846
Closed
1 task done

Stacking Reward Bags (100+) make then unable to be opened #157

Zapotoczny opened this issue Nov 2, 2021 · 2 comments · Fixed by #846
Labels
Area: Source Priority: Medium This issue may be impactful and needs some attention. Stale No activity Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@Zapotoczny
Copy link

Zapotoczny commented Nov 2, 2021 •
edited
Loading

What happened?

If you have in reward chest more than 100 reward bags and then u relog(befor relog is normal). All bags over 100 drop to the last bags and you can't open. this is because items start indexing at 101 and reward bag at 1(and when the "reward bag" index 101 falls into one another)
Where to change the start of sid and pid indexing
image

How to Reproduce?

Collect over 100 reward bags then reload and try to open one of the last

Relevant log output

No response

Attach any relevant file

No response

Version

10/12.x (10/12.x branch)

What OS are you seeing the problem on?

Linux

Code of Conduct

  • I agree to follow this project's Code of Conduct
@github-actions
Copy link
Contributor

This issue is stale because it has been open 120 days with no activity.

@github-actions github-actions bot added the Stale No activity label Feb 14, 2022
@andersonfaaria andersonfaaria added Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. Priority: Medium This issue may be impactful and needs some attention. Area: Source Status: Pending Test This PR or Issue requires more testing and removed Stale No activity labels Apr 5, 2022
@andersonfaaria andersonfaaria changed the title [Bug]: Reward chest Stacking Reward Bags (100+) make then unable to be opened Apr 5, 2022
@andersonfaaria andersonfaaria mentioned this issue Apr 5, 2022
Closed
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

This issue is stale because it has been open 120 days with no activity.

@github-actions github-actions bot added the Stale No activity label Jul 5, 2022
@murilo09 murilo09 linked a pull request Jan 15, 2023 that will close this issue
fix: empty reward bags should disappear after closing/opening reward chest #779
Closed
1 task
@ElimarCosta ElimarCosta mentioned this issue Feb 7, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Source Priority: Medium This issue may be impactful and needs some attention. Stale No activity Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
2 participants
@andersonfaaria @Zapotoczny