Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Reward chest bug #608

Closed
1 task done
Zapotoczny opened this issue Nov 30, 2021 · 1 comment · Fixed by #846
Closed
1 task done

[Bug]: Reward chest bug #608

Zapotoczny opened this issue Nov 30, 2021 · 1 comment · Fixed by #846
Labels
Area: Datapack Global Area: Source Priority: Medium This issue may be impactful and needs some attention. Stale No activity Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@Zapotoczny
Copy link

What happened?

If you have in reward chest more than 100 reward bags and then u relog(befor relog is normal). All bags over 100 drop to the last bags and you can't open. this is because items start indexing at 101 and reward bag at 1(and when the "reward bag" index 101 falls into one another)
Where to change the start of sid and pid indexing
image

I think the solution is to start sid with e.g. 10001
Propably need make some changes in boss_reward_chest.lua

How to Reproduce?

Collect over 100 reward bags then reload and try to open one of the last

Relevant log output

No response

Attach any relevant file

No response

Version

12.x (Default)

What OS are you seeing the problem on?

Ubuntu 18.04, Ubuntu 20.04

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Zapotoczny Zapotoczny added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Nov 30, 2021
@Zapotoczny Zapotoczny changed the title [Bug]: [Bug]: Reward chest bug Dec 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2022

This issue is stale because it has been open 120 days with no activity.

@github-actions github-actions bot added the Stale No activity label Mar 2, 2022
@andersonfaaria andersonfaaria added Priority: Medium This issue may be impactful and needs some attention. Area: Datapack Global Area: Source labels Apr 28, 2022
@dudantas dudantas transferred this issue from opentibiabr/otservbr-global Nov 9, 2022
@github-actions github-actions bot added the Status: Pending Test This PR or Issue requires more testing label Nov 9, 2022
@murilo09 murilo09 linked a pull request Jan 27, 2023 that will close this issue
fix: empty reward bags should disappear after closing/opening reward chest #779
Closed
1 task
@ElimarCosta ElimarCosta mentioned this issue Feb 7, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Datapack Global Area: Source Priority: Medium This issue may be impactful and needs some attention. Stale No activity Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
2 participants
@andersonfaaria @Zapotoczny