Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump to k8s 1.24 #83

Closed
wants to merge 7 commits into from
Closed

bump to k8s 1.24 #83

wants to merge 7 commits into from

Conversation

s-urbaniak
Copy link
Contributor

@s-urbaniak s-urbaniak commented Sep 19, 2022 •
edited
Loading

This is a follow-up of #81 using the right go version (1.17 vs. 1.19)

Fixes https://issues.redhat.com/browse/OCPBUGS-533 by pulling in kubernetes/kubernetes#109137 fixing kubernetes/kubernetes#109115.

@openshift-ci openshift-ci bot requested review from mrogers950 and stlaz September 19, 2022 15:11
@openshift-ci
Copy link

openshift-ci bot commented Sep 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2022
@ibihim @s-urbaniak
make update
e6163a4 
Signed-off-by: Krzysztof Ostrowski <kostrows@redhat.com>
@ibihim @s-urbaniak
pkg/oauth/apiserver: rename resources to lowercase
73be420 
We need to rename the resources to lower case due to
https://github.com/kubernetes/kubernetes/pull/108263/files

Signed-off-by: Krzysztof Ostrowski <kostrows@redhat.com>
@ibihim @s-urbaniak
p/u/a/r/useridentitymapping/test:add NamespaceNone
2cda871 
Add WithNamespace NamespaceNone as it is now required by upstream.

Signed-off-by: Krzysztof Ostrowski <kostrows@redhat.com>
@s-urbaniak
Copy link
Contributor Author

/test e2e-component

1 similar comment
@s-urbaniak
Copy link
Contributor Author

/test e2e-component

@s-urbaniak s-urbaniak changed the title bump to k8s 1.24 WIP: bump to k8s 1.24 Sep 20, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2022
@s-urbaniak
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2022
@s-urbaniak
Copy link
Contributor Author

@ibihim leaving up to you to take the state here vs. #81 as a continuation. many e2e's are green here. b14499c should be removed obviously.

@s-urbaniak
Copy link
Contributor Author

/test e2e-component

@s-urbaniak s-urbaniak force-pushed the pr-81 branch 2 times, most recently from 17eac04 to 0e3466b Compare October 5, 2022 17:33
@s-urbaniak s-urbaniak changed the title WIP: bump to k8s 1.24 bump to k8s 1.24 Oct 5, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 5, 2022
@s-urbaniak
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2022
@s-urbaniak
Copy link
Contributor Author

/test e2e-component

@s-urbaniak
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2022

@s-urbaniak: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-upgrade eaf296b link true /test e2e-aws-upgrade
ci/prow/e2e-aws-serial eaf296b link true /test e2e-aws-serial
ci/prow/e2e-aws eaf296b link true /test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@s-urbaniak
Copy link
Contributor Author

/close

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2022
@openshift-merge-robot
Copy link
Contributor

@s-urbaniak: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s-urbaniak
Copy link
Contributor Author

closing in favor of #81

@openshift-ci openshift-ci bot closed this Oct 8, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 8, 2022

@s-urbaniak: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s-urbaniak s-urbaniak deleted the pr-81 branch October 8, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrogers950 mrogers950 Awaiting requested review from mrogers950

@stlaz stlaz Awaiting requested review from stlaz

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s-urbaniak @openshift-merge-robot @ibihim