Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues in indexer caused by object changing the number of index values #109137

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Fix issues in indexer caused by object changing the number of index values #109137

merged 2 commits into from
Mar 30, 2022

Conversation

wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Mar 30, 2022 •
edited by liggitt
Loading

Fix #109115

Fix a 1.23 regression indexer bug that resulted in incorrect index updates if number of index values for a given object was changing during update

This was regressed in 1.23 by #105234

/kind bug
/sig api-machinery
/priority important-soon

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 30, 2022
@wojtek-t wojtek-t mentioned this pull request Mar 30, 2022
Closed
@k8s-ci-robot k8s-ci-robot requested review from deads2k and soltysh March 30, 2022 07:12
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2022
@wojtek-t wojtek-t mentioned this pull request Mar 30, 2022
Closed
@wojtek-t
Copy link
Member Author

Once merged - this should be cherrypicked to 1.23 - regression introduced in #105234

@wojtek-t
Copy link
Member Author

/assign @jpbetz

@aojea
Copy link
Member

aojea commented Mar 30, 2022

/lgtm

great report by the way
#109115 (comment)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2022
@wojtek-t
Copy link
Member Author

/retest

1 similar comment
@wojtek-t
Copy link
Member Author

/retest

@wojtek-t
Copy link
Member Author

Setting milestone as this is fixing regression introduced in 1.23 - @kubernetes/release-managers - FYI

/milestone v1.24

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 30, 2022
@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Mar 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2e55595 into kubernetes:master Mar 30, 2022
@wojtek-t wojtek-t mentioned this pull request Mar 30, 2022
Merged
k8s-ci-robot added a commit that referenced this pull request Mar 31, 2022
@k8s-ci-robot
Merge pull request #109159 from wojtek-t/automated-cherry-pick-of-#10…
4f9c753 
…9137-upstream-release-1.23

Automated cherry pick of #109137 upstream release 1.23
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 31, 2022
@github-actions github-actions bot mentioned this pull request Apr 5, 2022
Open
@sttts sttts mentioned this pull request Jul 5, 2022
Merged
@s-urbaniak s-urbaniak mentioned this pull request Oct 6, 2022
Closed
@sanchezl sanchezl mentioned this pull request Oct 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@jpbetz jpbetz

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

Client-go thread_safe_store removes still-valid values on update
7 participants
@wojtek-t @k8s-ci-robot @aojea @fedebongio @jpbetz @liggitt @MbolotSuse