Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-533: bump kube to 1.24.4 to fix group sync #81

Merged
merged 7 commits into from
Oct 8, 2022
Merged

OCPBUGS-533: bump kube to 1.24.4 to fix group sync #81

merged 7 commits into from
Oct 8, 2022

Conversation

ibihim
Copy link
Contributor

@ibihim ibihim commented Sep 8, 2022 •
edited
Loading

@openshift-ci openshift-ci bot requested review from deads2k and stlaz September 8, 2022 16:26
@ibihim
Copy link
Contributor Author

ibihim commented Sep 8, 2022

E0908 16:43:43.583604 1 run.go:74] "command failed" err="unable to install api resources: resource names must be lowercase only, not "userOAuthAccessTokens""

kubernetes/apiserver@7fd5822#diff-8a9e80dac2f71f42eec6f73ac6ed84f4475dd82e00123e592d134c9d5a43ab7cR662

@ibihim ibihim force-pushed the version-bump-for-custom-indexer branch 2 times, most recently from 134f715 to c691110 Compare September 12, 2022 19:20
@ibihim
go.mod: bump to k8s 1.24.4
660938c 
Signed-off-by: Krzysztof Ostrowski <kostrows@redhat.com>
@ibihim
vendor dependencies
bd63d6b 
Signed-off-by: Krzysztof Ostrowski <kostrows@redhat.com>
@ibihim
make update
e566f7e 
Signed-off-by: Krzysztof Ostrowski <kostrows@redhat.com>
@ibihim
pkg/oauth/apiserver: rename resources to lowercase
5eba7e0 
We need to rename the resources to lower case due to
https://github.com/kubernetes/kubernetes/pull/108263/files

Signed-off-by: Krzysztof Ostrowski <kostrows@redhat.com>
@ibihim ibihim force-pushed the version-bump-for-custom-indexer branch from c691110 to 5eba7e0 Compare September 13, 2022 08:23
@ibihim
p/u/a/r/useridentitymapping/test:add NamespaceNone
dd0c134 
Add WithNamespace NamespaceNone as it is now required by upstream.

Signed-off-by: Krzysztof Ostrowski <kostrows@redhat.com>
@ibihim
Copy link
Contributor Author

ibihim commented Sep 13, 2022

/retest-required

2 similar comments
@ibihim
Copy link
Contributor Author

ibihim commented Sep 13, 2022

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 14, 2022

/retest-required

@ibihim ibihim mentioned this pull request Sep 14, 2022
Closed
@ibihim
Copy link
Contributor Author

ibihim commented Sep 15, 2022

/retest-required

6 similar comments
@ibihim
Copy link
Contributor Author

ibihim commented Sep 15, 2022

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 15, 2022

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 16, 2022

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 16, 2022

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 16, 2022

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 19, 2022

/retest-required

@s-urbaniak s-urbaniak mentioned this pull request Sep 19, 2022
Closed
@ibihim
Copy link
Contributor Author

ibihim commented Sep 20, 2022

/retest-required

@ibihim ibihim force-pushed the version-bump-for-custom-indexer branch from f4bd23e to 4269a94 Compare September 20, 2022 17:00
@ibihim
Copy link
Contributor Author

ibihim commented Sep 21, 2022

/retest-required

1 similar comment
@ibihim
Copy link
Contributor Author

ibihim commented Sep 21, 2022

/retest-required

@ibihim ibihim changed the title bump kube to 1.24.4 [wip] bump kube to 1.24.4 Sep 22, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2022
@ibihim ibihim force-pushed the version-bump-for-custom-indexer branch from 8f3041f to 2c5936c Compare September 22, 2022 20:07
@ibihim
Copy link
Contributor Author

ibihim commented Oct 6, 2022

/retest-required

7 similar comments
@ibihim
Copy link
Contributor Author

ibihim commented Oct 6, 2022

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Oct 6, 2022

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Oct 6, 2022

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Oct 7, 2022

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Oct 7, 2022

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Oct 7, 2022

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Oct 7, 2022

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2022

@ibihim: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@s-urbaniak
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibihim, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2022
@openshift-merge-robot openshift-merge-robot merged commit 94026d8 into openshift:master Oct 8, 2022
@s-urbaniak
Copy link
Contributor

good stuff @ibihim !!!! 👏 This was a tough one 💪

@ibihim ibihim changed the title bump kube to 1.24.4 Bug OCPBUGS-533: bump kube to 1.24.4 Oct 10, 2022
@openshift-ci-robot
Copy link
Contributor

@ibihim: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-533 has been moved to the MODIFIED state.

In response to this:

What

  • Bump k8s deps to 1.24.4

Why

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ibihim ibihim changed the title Bug OCPBUGS-533: bump kube to 1.24.4 OCPBUGS-533: bump kube to 1.24.4 to fix group sync Oct 10, 2022
@ibihim ibihim deleted the version-bump-for-custom-indexer branch October 10, 2022 08:30
@ibihim
Copy link
Contributor Author

ibihim commented Oct 10, 2022

/cherry-pick release 4.11

@openshift-cherrypick-robot
Copy link

@ibihim: cannot checkout release 4.11: error checking out release 4.11: exit status 1. output: error: pathspec 'release 4.11' did not match any file(s) known to git

In response to this:

/cherry-pick release 4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ibihim
Copy link
Contributor Author

ibihim commented Oct 10, 2022

/cherry-pick release-4.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 10, 2022
Merged
@openshift-cherrypick-robot
Copy link

@ibihim: new pull request created: #84

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ibihim
Copy link
Contributor Author

ibihim commented Oct 13, 2022

/cherry-pick release 4.10

@openshift-cherrypick-robot
Copy link

@ibihim: cannot checkout release 4.10: error checking out release 4.10: exit status 1. output: error: pathspec 'release 4.10' did not match any file(s) known to git

In response to this:

/cherry-pick release 4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ibihim
Copy link
Contributor Author

ibihim commented Oct 13, 2022

/cherry-pick release-4.10

@openshift-cherrypick-robot
Copy link

@ibihim: #81 failed to apply on top of branch "release-4.10":

Applying: go.mod: bump to k8s 1.24.4
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
Falling back to patching base and 3-way merge...
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 go.mod: bump to k8s 1.24.4
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ibihim ibihim mentioned this pull request Oct 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@stlaz stlaz Awaiting requested review from stlaz

Assignees

@s-urbaniak s-urbaniak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Client-go thread_safe_store removes still-valid values on update
5 participants
@ibihim @s-urbaniak @openshift-ci-robot @openshift-cherrypick-robot @openshift-merge-robot