Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/metrics #1229

Closed
wants to merge 98 commits into from
Closed

Feature/metrics #1229

wants to merge 98 commits into from

Conversation

pjfitzgibbons
Copy link
Contributor

@pjfitzgibbons pjfitzgibbons commented Nov 2, 2022

Description

Squash-Merge of all changes for Observability Metrics feature

Signed-off-by: Peter Fitzgibbons pjfitz@amazon.com

Issues Resolved

[Metrics] Date Picker and Refresh Button opensearch-project/dashboards-observability#61
[Metrics] Home page opensearch-project/dashboards-observability#60
[Metrics] Save/Export Button opensearch-project/observability#1082
[Metrics] Available Metrics: List Metrics opensearch-project/dashboards-observability#42
[Metrics] Available Metrics: Interaction with Selected Metrics opensearch-project/dashboards-observability#59
[Metrics] Available Metrics: Creating Visual For Selected Metrics opensearch-project/observability#1091
[Metrics] Selected Metrics: List Metrics opensearch-project/dashboards-observability#58[Metrics] Display Visualizations opensearch-project/observability#1093
[Event] Save-as workflow for "Metric" type opensearch-project/dashboards-observability#139
[FEATURE][observability backend] Create Metric type and metadata schema for metric. opensearch-project/dashboards-observability#140
[Event] Add Subtype to Visualization API opensearch-project/observability#1194

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ps48 and others added 30 commits April 19, 2022 11:55
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>
* [OSD][Tests] add test subject to app title for app analytics

Using a test subject we can find the specific element instead
of trying to search the DOM for the class and hope the class
is the right class that contains the element we are looking for.

We can search the dom for this specific test subject and actually
make the test runner wait until this test subject exists before
executing the tests.

Issue related:
#679

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update one example for cypress tests

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
* Bump prismjs from 1.25.0 to 1.27.0 in /dashboards-observability (#508) (#574)

Bumps [prismjs](https://github.com/PrismJS/prism) from 1.25.0 to 1.27.0.
- [Release notes](https://github.com/PrismJS/prism/releases)
- [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md)
- [Commits](PrismJS/prism@v1.25.0...v1.27.0)

---
updated-dependencies:
- dependency-name: prismjs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit b4f491a)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* change to support java 8 in compile and runtime (#575) (#576)

Signed-off-by: Zhongnan Su <szhongna@amazon.com>
(cherry picked from commit 5c43e9d)

Co-authored-by: Zhongnan Su <szhongna@amazon.com>

* Add 1.3.0 release notes (#580) (#582)

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* bug fixes

Signed-off-by: Eric Wei <menwe@amazon.com>

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Zhongnan Su <szhongna@amazon.com>
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
…775)

* Added cypress test cases for tooltip and search engine on Trace dashboard

Signed-off-by: Pratibha Pandey <pratibha_pandey@persistent.com>

* Added test cases for filters

Signed-off-by: Pratibha Pandey <pratibha_pandey@persistent.com>

* Added cypress test cases for tooltip and search engine on Trace dashboard

Signed-off-by: Pratibha Pandey <pratibha_pandey@persistent.com>

* Added test cases for filters

Signed-off-by: Pratibha Pandey <pratibha_pandey@persistent.com>

* Added test cases for Service page in Trace analytics

Signed-off-by: Pratibha Pandey <pratibha_pandey@persistent.com>

* Added Cypress test cases for trace analytics services spans table

Signed-off-by: Deepak Nevde <deepak_nevde@persistent.com>

* Cypress test case for Traces

Signed-off-by: Nidhi Singhai <nidhi_singhai@persistent.com>

* Cypress test case for Traces Updated

Signed-off-by: Nidhi Singhai <nidhi_singhai@persistent.com>

* Worked on review comments

Signed-off-by: Pratibha Pandey <pratibha_pandey@persistent.com>

Co-authored-by: Deepak Nevde <deepak_nevde@persistent.com>
Co-authored-by: Nidhi Singhai <nidhi_singhai@persistent.com>
* rendered default axes selected and added error toasts on Save and Apply click if invalid value option selected

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

* Cypress changes for error toasts on invalid value options selected

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

* added constant VIZ_CONTAIN_XY_AXIS for x, y value axis

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>
* Initial commit for treemap visualization

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* changes to labelField, layout and config

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* reverted changes of layoutConfig

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* Cypress TestCase for TreeMap

Signed-off-by: Nidhi Singhai <nidhi_singhai@persistent.com>

* added new line

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* updated test cases

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* reverted snapshots

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* implemented treemap config options

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* added multicolored theme option

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* updated snapshots

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* Updated test scripts for multicolored section

Signed-off-by: Pratibha Pandey <pratibha_pandey@persistent.com>

* Fixed default selection for treemap

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

Co-authored-by: Nidhi Singhai <nidhi_singhai@persistent.com>
Co-authored-by: Pratibha Pandey <pratibha_pandey@persistent.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
* Added test cases for Notebooks application

Signed-off-by: Pratibha Pandey <pratibha_pandey@persistent.com>

* Added test cases for empty state of Notebooks table

Signed-off-by: Pratibha Pandey <pratibha_pandey@persistent.com>
…ases for same. (#776)

* pie chart legends, chart color contrast and cypress test cases

Signed-off-by: Deepak Nevde <deepak_nevde@persistent.com>

* Added color code in constants

Signed-off-by: Deepak Nevde <deepak_nevde@persistent.com>

* Snapshots updated

Signed-off-by: Deepak Nevde <deepak_nevde@persistent.com>

* Conflicts resolved

Signed-off-by: Deepak Nevde <deepak_nevde@persistent.com>

* Review comment addressed

Signed-off-by: Deepak Nevde <deepak_nevde@persistent.com>

* color variable changes

Signed-off-by: Deepak Nevde <deepak_nevde@persistent.com>
* Implementation of color theme for heatmap

Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>

* refactoring code

Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>

* HeatMap Cypress TestCase

Signed-off-by: Nidhi Singhai <nidhi_singhai@persistent.com>

* Cypress TestCase for HeatMap

Signed-off-by: Nidhi Singhai <nidhi_singhai@persistent.com>

* Update Done according to Comment

Signed-off-by: Nidhi Singhai <nidhi_singhai@persistent.com>

* Refactored code

Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>

* Updated snapshot test case

Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>

* Fixed toast implementation and no result found for heatmap

Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>

* Undefined checks for value options

Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>

Co-authored-by: Nidhi Singhai <nidhi_singhai@persistent.com>
* updated dimensions and metrics UI for pie chart

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* updated imports

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* updated snapshots

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>
* added support for multiple parents in treemap

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* minor type and position fixes

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* added default values for color pickers

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* resolved review comments

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* TreeMap Enhancement TestCases

Signed-off-by: Nidhi Singhai <nidhi_singhai@persistent.com>

* TreeMap Enhancement TestCases

Signed-off-by: Nidhi Singhai <nidhi_singhai@persistent.com>

* TreeMap Enhancement TestCases Updated

Signed-off-by: Nidhi Singhai <nidhi_singhai@persistent.com>

* Update Done

Signed-off-by: Nidhi Singhai <nidhi_singhai@persistent.com>

* fixed default parent color pickers state

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* fixed undefined check

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* updated snapshots

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

Co-authored-by: Nidhi Singhai <nidhi_singhai@persistent.com>
Co-authored-by: Subrat Pattnaik <subrat.pattnaik@hotmail.com>
…ion on config panel - 697 (#780)

* mode, orientation and rotate labels implementation under Chart style for Bar chart

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_button_group.tsx

* LineWidth and Fill-opacity changes

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/utils/utils.tsx

* Bar Group Width, Bar Width changes and rotated label hiding issue resolved

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

* corner cases handled for bar with and group Width and conditionally rendered rotate label UI

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

* Bar chart legend and color theme changes

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_legend.tsx

* Snapshots updated

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

* empty line added

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_button_group.tsx
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_legend.tsx

* review comment addressed

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_legend.tsx

* snapshot updated

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

* PR review comment addressed.

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_button_group.tsx

* add button constant added

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

* changed rgba to rgb in bar.tsx

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

* snapshot updated

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
* change version bump to maintenance

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* change version bump to maintenance

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
harshada8989 and others added 20 commits October 5, 2022 10:42
…Label (#1046)

* Data Configurations Panel UI implementation

Signed-off-by: harshada.lingayat <harshada_lingayat@persistent.com>

* Data Configurations Panel UI implementation

Signed-off-by: harshada.lingayat <harshada_lingayat@persistent.com>

* Review comments resolved

Signed-off-by: harshada.lingayat <harshada_lingayat@persistent.com>

* Made code compatible with PR changes

Signed-off-by: harshada.lingayat <harshada_lingayat@persistent.com>

* Custom Label two way sync implementation

Signed-off-by: harshada.lingayat <harshada_lingayat@persistent.com>

* Minor fix

Signed-off-by: harshada.lingayat <harshada_lingayat@persistent.com>

* internal review comments resolved

Signed-off-by: harshada.lingayat <harshada_lingayat@persistent.com>

* Review comments resolved

Signed-off-by: harshada.lingayat <harshada_lingayat@persistent.com>

* Comments resolved

Signed-off-by: harshada.lingayat <harshada_lingayat@persistent.com>

* Added tooltip in aggregation

Signed-off-by: harshada.lingayat <harshada_lingayat@persistent.com>

Signed-off-by: harshada.lingayat <harshada_lingayat@persistent.com>
* first

Signed-off-by: Abhay Pandey <abhay_pandey@persistent.com>

* number of gauge

Signed-off-by: Abhay Pandey <abhay_pandey@persistent.com>

* changes after rebase

Signed-off-by: Abhay Pandey <abhay_pandey@persistent.com>

* rebase

Signed-off-by: Abhay Pandey <abhay_pandey@persistent.com>

* number of gauges fixed in this commit

Signed-off-by: Abhay Pandey <abhay_pandey@persistent.com>

* removed the duplicate constant

Signed-off-by: Abhay Pandey <abhay_pandey@persistent.com>

Signed-off-by: Abhay Pandey <abhay_pandey@persistent.com>
* Fixed [BUG]: Visualization height panel issue for all charts

Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>

* Updated snapshots

Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>

* Reverted snapshots

Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>

* Reverted no_results.test.tsx.snap

Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>

* Reverted no_results.test.tsx.snap

Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>

Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>
Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>

Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>
* horizontal chart code integrated

Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>

* shape varibale updated

Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>

Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>
Signed-off-by: Derek Ho <dxho@amazon.com>

Signed-off-by: Derek Ho <dxho@amazon.com>
* Implemented horizontal bar vizualization + 2way sync

Signed-off-by: Dipra Aich <dipra_aich@persistent.com>

* Updated snapshots for test cases

Signed-off-by: Dipra Aich <dipra_aich@persistent.com>

* adjustments for rendering horiz_bars

Signed-off-by: Dipra Aich <dipra_aich@persistent.com>

* implemented commented changes for enhancements

Signed-off-by: Dipra Aich <dipra_aich@persistent.com>

* horiz_bar commented changes implemented

Signed-off-by: Dipra Aich <dipra_aich@persistent.com>

Signed-off-by: Dipra Aich <dipra_aich@persistent.com>
…esh button is hit, the app breaks. (#1110)

* fix for blank stats query breaking the app

Signed-off-by: Dipra Aich <dipra_aich@persistent.com>

* Eliminated isRefresh from fetchData

Signed-off-by: Dipra Aich <dipra_aich@persistent.com>

* fixed blank stats issue for gauge

Signed-off-by: Dipra Aich <dipra_aich@persistent.com>

* Removed span initialization for config

Signed-off-by: Dipra Aich <dipra_aich@persistent.com>

Signed-off-by: Dipra Aich <dipra_aich@persistent.com>
* default values updated in bar chart

Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>

* yarn test

Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>

* unsed lines of code removed

Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>

* yarn test

Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>

Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>
Signed-off-by: Vishal Kushwah <vishal.kushwah@domo.com>

Signed-off-by: Vishal Kushwah <vishal.kushwah@domo.com>
Co-authored-by: Vishal Kushwah <vishal.kushwah@domo.com>
* Fixed threshold crashes and color theme not applying on bar, line, scatter and histogram

Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>

* bugs fixed testing: in progress

Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>

* testing + fixing done

Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>

* bar crash fixed

Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>

* histogrm color theme options fixed

Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>

* log removed

Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>

Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>
Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>
Co-authored-by: ruchika-narang <ruchika_narang@persistent.com>
* Added Metrics Home Page and date picker

Signed-off-by: Sean Li <lnse@amazon.com>

* Minor changes

Signed-off-by: Sean Li <lnse@amazon.com>

Signed-off-by: Sean Li <lnse@amazon.com>
* Added Metrics Home Page and date picker

Signed-off-by: Sean Li <lnse@amazon.com>

* Minor changes

Signed-off-by: Sean Li <lnse@amazon.com>

* Adding empty view and sidebar

Signed-off-by: Sean Li <lnse@amazon.com>

Signed-off-by: Sean Li <lnse@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
* Added Metrics Home Page and date picker

Signed-off-by: Sean Li <lnse@amazon.com>

* Minor changes

Signed-off-by: Sean Li <lnse@amazon.com>

* Adding empty view and sidebar

Signed-off-by: Sean Li <lnse@amazon.com>

* Adding metrics reducer to redux store

Signed-off-by: Sean Li <lnse@amazon.com>

* Adding functioning sidebar to home page

Signed-off-by: Sean Li <lnse@amazon.com>

* Removing unnecessary function

Signed-off-by: Sean Li <lnse@amazon.com>

Signed-off-by: Sean Li <lnse@amazon.com>
* Save panel

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* remove comments

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* remove milliseconds from constants

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
* Adding API connects

Signed-off-by: Sean Li <lnse@amazon.com>

* Addressing constant chagne

Signed-off-by: Sean Li <lnse@amazon.com>

Signed-off-by: Sean Li <lnse@amazon.com>
* Add schema to router in events

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* update Saved Visualization in backend to include metrics

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* add SelectedLabels class

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* Add Token class in saved visualization

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* update test

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* fix frontend API data

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* update default subtype state to viz

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* disabling labels on front end

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* remove console.log comments

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* remove logger comments

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
* adding vizualization components

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* added metrics layout to redux

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* removed comments and updated constants

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* remove excess console.log

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@pjfitzgibbons pjfitzgibbons requested a review from a team as a code owner November 2, 2022 20:21
anirudha
anirudha previously approved these changes Nov 2, 2022
* Add Metrics to events home page and fix jest test

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* fix save_query_table jest test

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* fix backend test

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2022

Codecov Report

Merging #1229 (019ad23) into 2.4 (f1715e4) will increase coverage by 10.82%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##                2.4    opensearch-project/observability#1229       +/-   ##
=============================================
+ Coverage     59.53%   70.35%   +10.82%     
- Complexity      283      292        +9     
=============================================
  Files           237       42      -195     
  Lines          7752     2392     -5360     
  Branches       1553      248     -1305     
=============================================
- Hits           4615     1683     -2932     
+ Misses         2965      568     -2397     
+ Partials        172      141       -31     
Flag Coverage Δ
dashboards-observability ?
opensearch-observability 70.35% <ø> (-6.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rg/opensearch/observability/ObservabilityPlugin.kt 100.00% <ø> (ø)
...tlin/org/opensearch/observability/model/RestTag.kt 100.00% <ø> (ø)
...ensearch/observability/model/SavedVisualization.kt 60.73% <ø> (-33.17%) ⬇️
.../opensearch/observability/model/ScheduledJobDoc.kt 0.00% <ø> (ø)
.../observability/resthandler/SchedulerRestHandler.kt 6.66% <ø> (ø)
.../observability/scheduler/ObservabilityJobParser.kt 0.00% <ø> (ø)
.../observability/scheduler/ObservabilityJobRunner.kt 22.22% <ø> (ø)
... and 198 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

* Updating sidepanel

Signed-off-by: Sean Li <lnse@amazon.com>

* Removing mock metrics

Signed-off-by: Sean Li <lnse@amazon.com>

* Allowing horizontal scroll on metric lists

Signed-off-by: Sean Li <lnse@amazon.com>

* Minor changes

Signed-off-by: Sean Li <lnse@amazon.com>

Signed-off-by: Sean Li <lnse@amazon.com>
@ps48 ps48 marked this pull request as draft November 3, 2022 01:31
@ps48
Copy link
Member

ps48 commented Nov 3, 2022

Parked in drafts for a while.

@pjfitzgibbons
Copy link
Contributor Author

Superceded by PR #1234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.