Feature/metrics

.github/workflows/dashboards-observability-test-and-build-workflow.yml

@@ -6,7 +6,7 @@ on: [pull_request, push]
 env:
   PLUGIN_NAME: dashboards-observability
   OPENSEARCH_VERSION: 'main'
-  OPENSEARCH_PLUGIN_VERSION: 2.0.0.0
+  OPENSEARCH_PLUGIN_VERSION: 2.2.0.0
 
 jobs:
 

DEVELOPER_GUIDE.md

@@ -14,14 +14,13 @@ By default, tests use the same runtime as `JAVA_HOME`.
 
 ### Setup
 
-1. Download OpenSearch for the version that matches the [OpenSearch Dashboards version specified in package.json](./dashboards-observability/package.json#L5).
-1. Download the OpenSearch Dashboards source code for the [version specified in package.json](./dashboards-observability/package.json#L5) you want to set up.
-
+1. Download OpenSearch for the version that matches the [OpenSearch Dashboards version specified in opensearch_dashboards.json](./dashboards-observability/opensearch_dashboards.json#L4) from [opensearch.org](https://opensearch.org/downloads.html).
+1. Download the OpenSearch Dashboards source code for the [version specified in opensearch_dashboards.json](./dashboards-observability/opensearch_dashboards.json#L4) you want to set up.
 1. Change your node version to the version specified in `.node-version` inside the OpenSearch Dashboards root directory.
-1. cd into `plugins` directory in the OpenSearch Dashboards source code directory.
-1. Check out this package from version control into the `plugins` directory.
+1. cd into `OpenSearch-Dashboards` and remove the `plugins` directory.
+1. Check out this package from version control as the `plugins` directory.
 ```bash
-git clone git@github.com:opensearch-project/observability.git plugins --no-checkout
+git clone https://github.com/opensearch-project/observability plugins --no-checkout
 cd plugins
 echo 'dashboards-observability/*' >> .git/info/sparse-checkout
 git config core.sparseCheckout true
@@ -46,9 +45,7 @@ Example output: `./build/observability*.zip`
 
 ### Run
 
-- `yarn start`
-
-  Starts OpenSearch Dashboards and includes this plugin. OpenSearch Dashboards will be available on `localhost:5601`.
+cd back to `OpenSearch-Dashboards` directory and run `yarn start` to start OpenSearch Dashboards including this plugin. OpenSearch Dashboards will be available on `localhost:5601`.
 
 ### Submitting Changes
 
@@ -60,4 +57,4 @@ The Github workflow in [`backport.yml`](.github/workflows/backport.yml) creates
 with an appropriate label `backport <backport-branch-name>` is merged to main with the backport workflow run successfully on the
 PR. For example, if a PR on main needs to be backported to `1.x` branch, add a label `backport 1.x` to the PR and make sure the
 backport workflow runs on the PR along with other checks. Once this PR is merged to main, the workflow will create a backport PR
-to the `1.x` branch.
+to the `1.x` branch.

README.md

@@ -126,7 +126,7 @@ See [developer guide](DEVELOPER_GUIDE.md) and [how to contribute to this project
 
 If you find a bug, or have a feature request, please don't hesitate to open an issue in this repository.
 
-For more information, see [project website](https://opensearch.org/) and [documentation](https://opensearch.org/docs). If you need help and are unsure where to open an issue, try [forums](https://discuss.opendistrocommunity.dev/).
+For more information, see [project website](https://opensearch.org/) and [documentation](https://opensearch.org/docs). If you need help and are unsure where to open an issue, try the [Forum](https://forum.opensearch.org/c/plugins/observability/49).
 
 ## Code of Conduct
 

dashboards-observability/.cypress/integration/notebooks.spec.js → dashboards-observability/.cypress/integration/2_notebooks.spec.js

@@ -12,6 +12,8 @@ import {
   SAMPLE_URL,
   SQL_QUERY_TEXT,
   PPL_QUERY_TEXT,
+  NOTEBOOK_TEXT,
+  OPENSEARCH_URL,
 } from '../utils/constants';
 
 import { SAMPLE_PANEL } from '../utils/panel_constants';
@@ -63,6 +65,13 @@ describe('Testing notebooks table', () => {
     cy.visit(`${Cypress.env('opensearchDashboards')}/app/observability-dashboards#/notebooks`);
   });
 
+  it('Notebooks table empty state', () => {
+    cy.get('#notebookArea').contains('Notebooks (0)').should('exist');
+    cy.get('.euiTextAlign.euiTextAlign--center').contains('No notebooks');
+    cy.get('.euiButton__text').eq(2).contains('Create notebook');
+    cy.get('.euiButton__text').eq(3).contains('Add samples');
+  });
+
   it('Displays error toast for invalid notebook name', () => {
     cy.get('.euiButton__text').contains('Create notebook').click();
     cy.wait(delay);
@@ -125,6 +134,21 @@ describe('Testing notebooks table', () => {
       .should('exist');
   });
 
+  it('Notebooks table columns headers and pagination', () => {
+    cy.get('.euiTitle.euiTitle--small').contains('Notebooks').should('exist');
+    cy.get('.euiTableCellContent__text[title="Name"]').should('exist');
+    cy.get('.euiTableCellContent__text[title="Last updated"]').should('exist');
+    cy.get('.euiTableCellContent__text[title="Created"]').should('exist');
+    cy.get('[data-test-subj="tablePaginationPopoverButton"]').should('exist');
+  });
+
+  it('"Learn more" link under Notebooks header', () => {
+    cy.get('.euiTitle.euiTitle--small').contains('Notebooks');
+    cy.get('.euiTextColor.euiTextColor--subdued').contains(NOTEBOOK_TEXT);
+    cy.get('a.euiLink.euiLink--primary').contains('Learn more').click();
+    cy.get(`a[href="${OPENSEARCH_URL}"]`).should('exist');
+  });
+
   it('Deletes notebooks', () => {
     cy.get('.euiCheckbox__input[data-test-subj="checkboxSelectAll"]').click();
     cy.wait(delay);
@@ -231,6 +255,16 @@ describe('Testing paragraphs', () => {
     cy.get('.euiTitle').contains('Event analytics').should('exist');
   });
 
+  it('Paragraph actions layout', () => {
+    cy.get('button[data-test-subj="notebook-paragraph-actions-button"]').should('exist').click();
+    cy.get('.euiContextMenuPanelTitle').contains('Actions');
+    cy.get('.euiContextMenuItem__text').eq(0).contains('Add paragraph to top');
+    cy.get('.euiContextMenuItem__text').eq(1).contains('Add paragraph to bottom');
+    cy.get('.euiContextMenuItem__text').eq(2).contains('Run all paragraphs');
+    cy.get('.euiContextMenuItem__text').eq(3).contains('Clear all outputs');
+    cy.get('.euiContextMenuItem__text').eq(4).contains('Delete all paragraphs');
+  });
+
   it('Renders markdown', () => {
     cy.get('.euiTextArea').should('not.exist');
     cy.get(`a[href="${SAMPLE_URL}"]`).should('exist');

dashboards-observability/.cypress/integration/panels.spec.js → dashboards-observability/.cypress/integration/3_panels.spec.js

@@ -502,37 +502,7 @@ describe('Testing a panel', () => {
   });
 });
 
-describe('Add samples and clean up all test data', () => {
-  it('Add sample data', () => {
-    moveToPanelHome();
-    cy.get('.euiButton__text').contains('Actions').trigger('mouseover').click();
-    cy.wait(delay);
-    cy.get('.euiContextMenuItem__text').contains('Add samples').trigger('mouseover').click();
-    cy.wait(delay * 3);
-    cy.get('.euiModalHeader__title[data-test-subj="confirmModalTitleText"]')
-      .contains('Add samples')
-      .should('exist');
-    cy.wait(delay);
-    cy.get('.euiButton__text').contains('Yes').trigger('mouseover').click();
-    cy.wait(delay * 5);
-    cy.route2('POST', '/addSamplePanels').as('removePage');
-    cy.wait('@removePage').then(() => {
-      cy.get('.euiTableCellContent').contains(SAMPLE_PANEL).should('exist');
-    });
-    cy.wait(delay);
-  });
-
-  it('Validate sample data', () => {
-    moveToPanelHome();
-    cy.get('.euiTableCellContent').contains(SAMPLE_PANEL).trigger('mouseover').click();
-    cy.wait(delay * 3);
-    cy.get('h1').contains(SAMPLE_PANEL).should('exist');
-    cy.wait(delay);
-    SAMPLE_VISUALIZATIONS_NAMES.forEach((vizName) =>
-      cy.get('h5').contains(vizName).should('exist')
-    );
-    cy.wait(delay);
-  });
+describe('Clean up all test data', () => {
 
   it('Delete visualizations from event analytics', () => {
     moveToEventsHome();
@@ -572,3 +542,4 @@ describe('Add samples and clean up all test data', () => {
     cy.get('.euiTextAlign').contains('No Operational Panels').should('exist');
   });
 });
+