Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Updated data configuration UI and Two way sync for Custom Label #1046

Merged

Conversation

harshada8989
Copy link
Contributor

Description

  1. Updated UI for Data Configuration Panel referred from https://playground.opensearch.org/app/wizard#/
  2. Implemented two-way sync for label
  3. Renamed alias to custom label

Issues Resolved

#1020
#1038

Check List

  • New functionality includes a change of Data configuration UI and two-way sync for the custom label.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@harshada8989 harshada8989 requested a review from a team as a code owner September 27, 2022 13:21
@DipraAich DipraAich force-pushed the feature/Data-Config-UI branch from 8d6c9c3 to fcfda9c Compare September 28, 2022 08:21
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2022

Codecov Report

Merging #1046 (4da4e2a) into main (e9ff79a) will decrease coverage by 0.02%.
The diff coverage is 29.41%.

@@             Coverage Diff              @@
##               main    #1046      +/-   ##
============================================
- Coverage     53.59%   53.57%   -0.03%     
  Complexity      291      291              
============================================
  Files           280      280              
  Lines          9341     9352      +11     
  Branches       2155     2161       +6     
============================================
+ Hits           5006     5010       +4     
- Misses         4165     4172       +7     
  Partials        170      170              
Flag Coverage Δ
dashboards-observability 47.56% <29.41%> (-0.02%) ⬇️
opensearch-observability 71.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../common/query_manager/ast/builder/stats_builder.ts 0.00% <ø> (ø)
...mmon/query_manager/ast/expression/AggregateTerm.ts 0.00% <ø> (ø)
...ublic/components/visualizations/charts/bar/bar.tsx 12.00% <0.00%> (ø)
...ponents/visualizations/charts/helpers/viz_types.ts 29.90% <0.00%> (-2.10%) ⬇️
...ic/components/visualizations/charts/lines/line.tsx 31.63% <ø> (ø)
.../components/visualizations/charts/maps/heatmap.tsx 6.25% <ø> (ø)
...ublic/components/visualizations/charts/pie/pie.tsx 46.15% <ø> (ø)
...g_panes/config_controls/config_treemap_parents.tsx 5.26% <7.69%> (ø)
...nfig_panes/config_controls/config_style_slider.tsx 66.66% <50.00%> (ø)
...hboards-observability/common/constants/explorer.ts 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mengweieric
Copy link
Collaborator

mengweieric commented Sep 30, 2022

Please address the failing tests and new comments added.

@harshada8989 harshada8989 force-pushed the feature/Data-Config-UI branch from e771b5d to 8742fa3 Compare October 3, 2022 17:44
Signed-off-by: harshada.lingayat <harshada_lingayat@persistent.com>
Signed-off-by: harshada.lingayat <harshada_lingayat@persistent.com>
Signed-off-by: harshada.lingayat <harshada_lingayat@persistent.com>
Signed-off-by: harshada.lingayat <harshada_lingayat@persistent.com>
Signed-off-by: harshada.lingayat <harshada_lingayat@persistent.com>
Signed-off-by: harshada.lingayat <harshada_lingayat@persistent.com>
Signed-off-by: harshada.lingayat <harshada_lingayat@persistent.com>
Signed-off-by: harshada.lingayat <harshada_lingayat@persistent.com>
Signed-off-by: harshada.lingayat <harshada_lingayat@persistent.com>
Signed-off-by: harshada.lingayat <harshada_lingayat@persistent.com>
@harshada8989 harshada8989 force-pushed the feature/Data-Config-UI branch from f6bf582 to 4da4e2a Compare October 4, 2022 12:56
Copy link
Collaborator

@mengweieric mengweieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the changes to all the reviews.

@mengweieric mengweieric merged commit 1f605e2 into opensearch-project:main Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants