Apply Spotless after release #17016
Apply Spotless after release #17016
Conversation
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
|
@lsiepel - this seems fishy? "openhab-addons: Prepare next version" is still running, maybe let's wait and see it looks after that? |
|
I agree that we should wait a bit. openhab-core would already be ready to be updated. |
|
No need to rush, this PR is here ready to be merged whenever the task is completed. :-) |
|
Okay, checking Git history, I found #16097. So it seems the maven plugin makes these undesired changes besides bumping version number, and we then manually revert them right after. And we live with that, because we don't know how to avoid it. Correct? 🙂 |
|
Yep, that's correct. |
Yes, see openhab/openhab-core#3952 (comment) I remember this XML multiple lines issue also occurred elsewhere. Can’t find the link. I think it had to do with inconsistent behaviour of spotless on all operating systems. |
* Spotless Signed-off-by: Leo Siepel <leosiepel@gmail.com>
* Spotless Signed-off-by: Leo Siepel <leosiepel@gmail.com> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
* Spotless Signed-off-by: Leo Siepel <leosiepel@gmail.com>
* Spotless Signed-off-by: Leo Siepel <leosiepel@gmail.com>
* Spotless Signed-off-by: Leo Siepel <leosiepel@gmail.com> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Applied spotless to fix the build after deployment script did something 'extra'.