Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shelly] Revise fix for Gen1 initialization problem for manually created Things #17011

Merged
merged 9 commits into from
Jul 9, 2024
Merged

[shelly] Revise fix for Gen1 initialization problem for manually created Things #17011

merged 9 commits into from
Jul 9, 2024

Conversation

markus7017
Copy link
Contributor

This PR replaces #17009 with a more solid solution supporting gen 1/2/3 devices discovered by UI for defined in a .things file

markus7017 added 2 commits July 7, 2024 09:38
@markus7017
Fixes openhab#16990 - Gen1 nbo longer initializes when defined in .th…
45a93a9 
…ings

Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017
Revised fix for Gen1 initialization problem
45e4f20 
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017 markus7017 self-assigned this Jul 7, 2024
@markus7017 markus7017 requested a review from jlaur July 7, 2024 14:34
@markus7017 markus7017 mentioned this pull request Jul 7, 2024
Merged
@markus7017
Merge branch 'main' into shelly_gen1fix_2
5c87699 
Signed-off-by: Markus Michels <markus7017@gmail.com>
@jlaur
Copy link
Contributor

jlaur commented Jul 7, 2024

Related to https://github.com/openhab/openhab-addons/pull/17009/files#r1667631650

Since I proposed this change, I would appreciate another @openhab/add-ons-maintainers to have a look.

jlaur
jlaur approved these changes Jul 7, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur linked an issue Jul 7, 2024 that may be closed by this pull request
[shelly] Improve reliability in API determination #17013
Closed
@jlaur jlaur changed the title [shelly] Revised fox for Gen1 initialization problem when defined in .things [shelly] Revise fix for Gen1 initialization problem for manually created Things Jul 7, 2024
jlaur
jlaur requested changes Jul 7, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #17013 (comment)

@jlaur
Copy link
Contributor

jlaur commented Jul 7, 2024

@markus7017 - what remains for this PR is to verify if shellywalldisplay should use API for generation 1 or 2.

markus7017 added 2 commits July 7, 2024 21:54
@markus7017
REAMDME updated
1aed1b5
@markus7017
README updated
0837302 
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017
Copy link
Contributor Author

  • README updated
  • A bug in Gen3 init resulting in isGen2 = false
  • shellywalldisplay added to isGeneration2()

jlaur
jlaur requested changes Jul 7, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor README comments.

@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Jul 7, 2024
markus7017 added 2 commits July 7, 2024 23:03
@markus7017
review changes applied
22bb463 
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017
Typo fixed
36309f7 
Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017
Copy link
Contributor Author

@jlaur why is there a problem with pom.xml so CI builds fail?

@jlaur
Copy link
Contributor

jlaur commented Jul 7, 2024

why is there a problem with pom.xml so CI builds fail?

This is related to the current build of 4.2.0, where pom files have been updated with new version number, but without applying spotless. #17016 will fix that. Don't worry about it, we can trigger rebuild after that PR is merged.

@markus7017
Copy link
Contributor Author

@jlaur anything open for this PR?

@jlaur jlaur mentioned this pull request Jul 7, 2024
Merged
@jlaur
Update bundles/org.openhab.binding.shelly/README.md
56f1aa2 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur
Update bundles/org.openhab.binding.shelly/README.md
e044c89 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur
jlaur approved these changes Jul 7, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@jlaur jlaur requested a review from lolodomo July 7, 2024 21:20
@jlaur jlaur added the rebuild Triggers Jenkins PR build label Jul 7, 2024
@jlaur jlaur removed the rebuild Triggers Jenkins PR build label Jul 7, 2024
@markus7017
Copy link
Contributor Author

LGTM

@lsiepel lsiepel merged commit 7755681 into openhab:main Jul 9, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Jul 9, 2024
jlaur added a commit that referenced this pull request Jul 9, 2024
@markus7017 @jlaur
[shelly] Revise fix for Gen1 initialization problem for manually crea…
d5d01dc 
…ted Things (#17011)

* Fixes #16990 - Gen1 nbo longer initializes when defined in .things

Signed-off-by: Markus Michels <markus7017@gmail.com>

Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added the patch A PR that has been cherry-picked to a patch release branch label Jul 9, 2024
@jlaur jlaur mentioned this pull request Jul 10, 2024
Merged
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jul 12, 2024
@markus7017 @jlaur @psmedley
[shelly] Revise fix for Gen1 initialization problem for manually crea…
1e671d5 
…ted Things (openhab#17011)

* Fixes openhab#16990 - Gen1 nbo longer initializes when defined in .things

Signed-off-by: Markus Michels <markus7017@gmail.com>

Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
@markus7017 @jlaur @pgfeller
[shelly] Revise fix for Gen1 initialization problem for manually crea…
ba30710 
…ted Things (openhab#17011)

* Fixes openhab#16990 - Gen1 nbo longer initializes when defined in .things

Signed-off-by: Markus Michels <markus7017@gmail.com>

Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@markus7017 @jlaur @joni1993
[shelly] Revise fix for Gen1 initialization problem for manually crea…
fdaa5fe 
…ted Things (openhab#17011)

* Fixes openhab#16990 - Gen1 nbo longer initializes when defined in .things

Signed-off-by: Markus Michels <markus7017@gmail.com>

Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
@markus7017 @jlaur @matchews
[shelly] Revise fix for Gen1 initialization problem for manually crea…
a97112b 
…ted Things (openhab#17011)

* Fixes openhab#16990 - Gen1 nbo longer initializes when defined in .things

Signed-off-by: Markus Michels <markus7017@gmail.com>

Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
@markus7017 @jlaur
[shelly] Revise fix for Gen1 initialization problem for manually crea…
aabd126 
…ted Things (openhab#17011)

* Fixes openhab#16990 - Gen1 nbo longer initializes when defined in .things

Signed-off-by: Markus Michels <markus7017@gmail.com>

Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@lolodomo lolodomo Awaiting requested review from lolodomo

Assignees

@markus7017 markus7017

Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

[shelly] Improve reliability in API determination
3 participants
@markus7017 @jlaur @lsiepel