Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotless problem in v4.2 #3952

Closed
andrewfg opened this issue Dec 22, 2023 · 3 comments · Fixed by #3953
Closed

Spotless problem in v4.2 #3952

andrewfg opened this issue Dec 22, 2023 · 3 comments · Fixed by #3953
Labels
bug An unexpected problem or unintended behavior of the Core

Comments

@andrewfg
Copy link
Contributor

andrewfg commented Dec 22, 2023

It looks like in the switchover from v4.1 to v4.2 somebody changed the spotless formatter parameters. So running 'mvn spotless:apply' locally reformats all of the 138 local 'pom.xml' files. And since nobody has yet run the new 'mvn spotless:apply' on the pom.xml files on github main, this means that a correctly formatted PR will now include all of those 138 files in the diff versus OH main.

EDIT: I think it may be the other way round. The 138 'pom.xml' files on github were reformatted, to a layout that is incompatible with the output produced by running 'mvn spotless:apply' locally.

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

@andrewfg andrewfg added the bug An unexpected problem or unintended behavior of the Core label Dec 22, 2023
@andrewfg
Copy link
Contributor Author

@holgerfriedrich / @J-N-K the same fix should be applied to openhab-core

@holgerfriedrich
Copy link
Member

@J-N-K @wborn I think I need to resolve the bundles in itests again.... Can you assist how to do this?

@J-N-K
Copy link
Member

J-N-K commented Dec 22, 2023

@andrewfg We always do that after an release, but it has to be done manually, unfortunately.

@holgerfriedrich mvn spotless:apply clean install -DwithResolver=true -T 1.5C is what I usually use. It applies spotless, does a full build with bundle resolving and in parallel with 1.5 threads per core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants