Feature/kevin/email notifications panel #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d email notification settings
…ght organization for applicaiton.scss to match studio sass breakdown.
…compiling, added in initial icon references
…d fontawesome icons into discusison home with basic positioning
…or the rest of _discussion.scss
…d email notification settings
…ght organization for applicaiton.scss to match studio sass breakdown.
…compiling, added in initial icon references
…d fontawesome icons into discusison home with basic positioning
…or the rest of _discussion.scss
|
@jimabramson please review |
| @@ -82,6 +82,9 @@ class @DiscussionUtil | |||
| user_profile : "/courses/#{$$course_id}/discussion/forum/users/#{param}" | |||
| followed_threads : "/courses/#{$$course_id}/discussion/forum/users/#{param}/followed" | |||
| threads : "/courses/#{$$course_id}/discussion/forum" | |||
| "enable_notifications" : "/notification_prefs/enable/" | |||
| "disable_notifications" : "/notification_prefs/disable/" | |||
| "notifications_status" : "/user_api/v1/user_prefs/?key=notification_pref&use=#{param}" | |||
There was a problem hiding this comment.
i think use= param is a typo, but i also think you don't need it, since this is ajax and the user comes from auth. (the operation is working for me in manual tests)
…hub.com/edx/edx-platform into feature/kevin/email_notifications_panel
|
feature flag worked for me in testing on local. |
…edx/edx-platform into feature/kevin/email_notifications_panel
|
@ormsbee mind sanity-checking the feature flag? lms/envs/{common/aws}.py + lms/templates/discussion/_underscore_templates.html |
added 2 commits
July 30, 2013 02:30
…hub.com/edx/edx-platform into feature/kevin/email_notifications_panel
|
👍 |
jimabramson
pushed a commit
that referenced
this pull request
Jul 30, 2013
Feature/kevin/email notifications panel
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
add user profile and fixed edit
Kelketek
referenced
this pull request
in open-craft/edx-platform
Sep 17, 2015
Remove extraneous width setting from .response-header-actions
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
Co-authored-by: Renovate Bot <bot@renovateapp.com>
farhaanbukhsh
pushed a commit
that referenced
this pull request
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update discussion panel to show instructions and toggle email notifications on and off as a feature flag.