Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSD] add annotations for ENABLE_DISCUSSION_HOME_PANEL feature flag #26870

Merged

Conversation

jramnai
Copy link
Contributor

@jramnai jramnai commented Mar 5, 2021

Description

This PR adds annotaions for ENABLE_DISCUSSION_HOME_PANEL feature flag.

Supporting information

https://github.com/edx/edx-platform/pull/520

This feature flag is False in lms/envs/common.py but from the ansible config its value is True by default, that's why I have added toggle_default as True.

@openedx-webhooks
Copy link

Thanks for the pull request, @jramnai! I've created OSPR-5654 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Mar 5, 2021
@jramnai
Copy link
Contributor Author

jramnai commented Mar 5, 2021

@natabene, I don't know why the test cases are failing, can you or anybody else help me with it?

@natabene
Copy link
Contributor

natabene commented Mar 5, 2021

@jramnai Thank you for your contribution! @eLRuLL @BbrSofiane Would you be able with tests?

@eLRuLL
Copy link
Contributor

eLRuLL commented Mar 8, 2021

👍 this looks good to merge @edx/doc-a-thon-reviewers

@jramnai looks like a temporary failure, maybe try rerunning this (push again?)

@jramnai jramnai force-pushed the tsd-enable_discussion_home_panel branch from a760f39 to 6848705 Compare March 8, 2021 15:29
@openedx-webhooks openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs triage labels Mar 8, 2021
@jramnai
Copy link
Contributor Author

jramnai commented Mar 8, 2021

jenkins run all

@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@felipemontoya felipemontoya merged commit dabfa5f into openedx:master Mar 10, 2021
@openedx-webhooks openedx-webhooks added merged waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Mar 10, 2021
@openedx-webhooks
Copy link

@jramnai 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

@felipemontoya
Copy link
Member

Thanks @jramnai @natabene @eLRuLL 👍 👍 👍 👍

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@natabene
Copy link
Contributor

@felipemontoya @eLRuLL Thank you so much!

@jramnai jramnai deleted the tsd-enable_discussion_home_panel branch March 12, 2021 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants