-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TSD] add annotations for ENABLE_DISCUSSION_HOME_PANEL feature flag #26870
[TSD] add annotations for ENABLE_DISCUSSION_HOME_PANEL feature flag #26870
Conversation
Thanks for the pull request, @jramnai! I've created OSPR-5654 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@natabene, I don't know why the test cases are failing, can you or anybody else help me with it? |
@jramnai Thank you for your contribution! @eLRuLL @BbrSofiane Would you be able with tests? |
👍 this looks good to merge @edx/doc-a-thon-reviewers @jramnai looks like a temporary failure, maybe try rerunning this (push again?) |
a760f39
to
6848705
Compare
jenkins run all |
Your PR has finished running tests. There were no failures. |
@jramnai 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
EdX Release Notice: This PR has been deployed to the production environment. |
@felipemontoya @eLRuLL Thank you so much! |
Description
This PR adds annotaions for
ENABLE_DISCUSSION_HOME_PANEL
feature flag.Supporting information
https://github.com/edx/edx-platform/pull/520
This feature flag is
False
inlms/envs/common.py
but from the ansible config its value isTrue
by default, that's why I have addedtoggle_default
asTrue
.