-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/kevin/email notifications panel #520
Merged
Merged
Changes from all commits
Commits
Show all changes
98 commits
Select commit
Hold shift + click to select a range
15de412
blankslate edited, header bar now with home button
marcotuts 7ddb7a6
Merge branch 'master' into feature/marco/discussionhome
marcotuts 57c513b
basic shell for discussion home page with both profile information an…
marcotuts 0936e61
addition of font-awesome to LMS sass vendor assets, in additio nto li…
marcotuts 714a3f1
added in vendor font references to lms for font-awesome
marcotuts f213113
cleaned up font-awesome integration to work with new mako file .scss …
marcotuts 786d8a9
cleaned up variables styling to sync up closer to studio, incorporate…
marcotuts c63fb7c
basic shell for home page exists, along with start of color cleanup f…
marcotuts 03d5145
removed border to the right of discussion list
marcotuts 73e1227
cleaned up margin and padding to use baseline variable
marcotuts 48f4769
sass build cleanup for baseline fixes
marcotuts e515857
icon color changes and profile link style to match profile page
marcotuts 1af4d90
removed icon stack from email area of helpgrid
marcotuts b946a10
cleaned up topic header to allow for multiple line titles still being…
marcotuts b6c4cc4
new post button using font-awesome
marcotuts b9d97e4
removed new post icon and added font-awesome replacement
marcotuts d5105b7
updated flag icons to be font-awesome based
marcotuts 163610d
updated pinning icons and removed images
marcotuts 3df08dc
blankslate edited, header bar now with home button
marcotuts 46998bd
basic shell for discussion home page with both profile information an…
marcotuts 8ef258d
addition of font-awesome to LMS sass vendor assets, in additio nto li…
marcotuts 38d8863
added in vendor font references to lms for font-awesome
marcotuts 23f1942
cleaned up font-awesome integration to work with new mako file .scss …
marcotuts 5240342
cleaned up variables styling to sync up closer to studio, incorporate…
marcotuts b870679
basic shell for home page exists, along with start of color cleanup f…
marcotuts d648b18
removed border to the right of discussion list
marcotuts 74ea364
cleaned up margin and padding to use baseline variable
marcotuts 9fe6264
sass build cleanup for baseline fixes
marcotuts 07e87a5
icon color changes and profile link style to match profile page
marcotuts b83d5aa
removed icon stack from email area of helpgrid
marcotuts 98cd032
cleaned up topic header to allow for multiple line titles still being…
marcotuts 0f84a52
new post button using font-awesome
marcotuts 770bfdc
removed new post icon and added font-awesome replacement
marcotuts 05a7d66
updated flag icons to be font-awesome based
marcotuts a24c3a9
updated pinning icons and removed images
marcotuts 84d505e
modified html for discussion home to use tables instead of lists, cle…
marcotuts f94ec6c
merge conflicts resolved
marcotuts fbd0f1b
wire up static HTML to allow panel functionality
kevinchugh 6e2de9d
tweak css and fix merge conflicts
kevinchugh 63b2b47
update to render home page
kevinchugh 17f4579
blankslate edited, header bar now with home button
marcotuts 8886b59
basic shell for discussion home page with both profile information an…
marcotuts 8216bb6
addition of font-awesome to LMS sass vendor assets, in additio nto li…
marcotuts 0812867
added in vendor font references to lms for font-awesome
marcotuts 1fe54ba
cleaned up font-awesome integration to work with new mako file .scss …
marcotuts 6657ac1
cleaned up variables styling to sync up closer to studio, incorporate…
marcotuts f674e61
basic shell for home page exists, along with start of color cleanup f…
marcotuts b55b34f
removed border to the right of discussion list
marcotuts a0f54aa
cleaned up margin and padding to use baseline variable
marcotuts ff9f571
sass build cleanup for baseline fixes
marcotuts d2fae78
icon color changes and profile link style to match profile page
marcotuts 1a267a5
removed icon stack from email area of helpgrid
marcotuts 90e60c1
cleaned up topic header to allow for multiple line titles still being…
marcotuts e277946
new post button using font-awesome
marcotuts 642b649
removed new post icon and added font-awesome replacement
marcotuts 0e0ceb4
updated flag icons to be font-awesome based
marcotuts 9c45293
updated pinning icons and removed images
marcotuts 8d49007
blankslate edited, header bar now with home button
marcotuts 38e040a
basic shell for discussion home page with both profile information an…
marcotuts 2c9e4ca
addition of font-awesome to LMS sass vendor assets, in additio nto li…
marcotuts 37c9de7
cleaned up font-awesome integration to work with new mako file .scss …
marcotuts e2f02cd
cleaned up variables styling to sync up closer to studio, incorporate…
marcotuts e87d071
basic shell for home page exists, along with start of color cleanup f…
marcotuts a9ea00a
removed border to the right of discussion list
marcotuts 78ffc12
cleaned up margin and padding to use baseline variable
marcotuts d8498bf
new post button using font-awesome
marcotuts 646ff9e
removed new post icon and added font-awesome replacement
marcotuts 9eca557
updated flag icons to be font-awesome based
marcotuts 3495ceb
modified html for discussion home to use tables instead of lists, cle…
marcotuts 83b4dc6
final cleanup from git rebase
marcotuts 747102c
additional git rebase cleanup
marcotuts 5b3cb53
visual cleanup for discussion home bar
marcotuts 820544c
pin and flag icons using fontawesome now render properly through inli…
marcotuts 77a23a3
reordered email settings checkbox to impact styling for icon and clea…
marcotuts 5d106ee
Merge branch 'master' into feature/kevin/email_notifications_panel
kevinchugh d95693e
hook up panel to new stats service
kevinchugh 6276997
update checkbox with get settings
kevinchugh 13ca61b
fix merge conflict with _variables.scss
kevinchugh 7507921
merge with Marcos new design
kevinchugh 4afa548
set and get settings and fix discussion.css post-variable-apocalypse
kevinchugh b7d6d77
visual cleanup for email icon and discussion context label post branc…
marcotuts 33d4ae6
add feature flag to enable/disable discussion home panel
06eb5cd
Merge branch 'feature/kevin/email_notifications_panel' of https://git…
47dbf2e
updates but getting status and setting status not working
kevinchugh 62f6e2d
home button working, default to home when no thread selected
kevinchugh 99f235e
first pass at jasmine tests
kevinchugh 0207255
fix strange comment typo
8f98a1c
remove failing jasmine tests and print statements
kevinchugh 79994b5
Merge branch 'feature/kevin/email_notifications_panel' of https://git…
803b92f
add ajax endpoint for getting notifications status
kevinchugh 986a2cd
Merge branch 'feature/kevin/email_notifications_panel' of github.com:…
kevinchugh 908fd46
notification_prefs: add ajax endpoint to get preference status
5c91edd
update coffeescript to use new status url
kevinchugh c3e609f
fix merge conflict
kevinchugh 4f7edbf
fix notifications URL
kevinchugh e1e591f
address code review comments
kevinchugh 7a7c070
notification_prefs/views: correct docstring
05f31f8
Merge branch 'feature/kevin/email_notifications_panel' of https://git…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does thread:removed do something related to the home button?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it loads all threads with none selected. if the user clicks a thread, then clicks home, then hits refresh, we don't want to reload the previous selected thread, this accomplishes that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it