Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve contributor workflow #616

Merged
merged 6 commits into from
Jan 27, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: run test pods with role label rather than appRole
Makes it the same as the lvm-localpv.

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
  • Loading branch information
tiagolobocastro committed Jan 21, 2025
commit 442f220c8c7468160a22d64d82a6fdb060b35b49
4 changes: 2 additions & 2 deletions ci/ci-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ cleanup() {
echo "Cleaning up test resources"

if kubectl get nodes 2>/dev/null; then
kubectl delete deployment -lappRole=test -n "$OPENEBS_NAMESPACE"
kubectl delete pod -lappRole=test --force -n "$OPENEBS_NAMESPACE"
kubectl delete deployment -lrole=test -n "$OPENEBS_NAMESPACE"
kubectl delete pod -lrole=test --force -n "$OPENEBS_NAMESPACE"
kubectl delete pvc -n "$OPENEBS_NAMESPACE" --all

sleep 3
Expand Down
4 changes: 3 additions & 1 deletion tests/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,7 @@ func createAndDeployAppPod(appname string, pvcname string) {
var err error
labels := map[string]string{
"app": "busybox",
"role": "test",
"appName": appname,
}
ginkgo.By("building a busybox app pod deployment using above zfs volume")
Expand Down Expand Up @@ -548,6 +549,7 @@ func createAndDeployBlockAppPod() {
var err error
labels := map[string]string{
"app": "busybox",
"role": "test",
"appName": appName,
}
ginkgo.By("building a busybox app pod deployment using above zfs volume")
Expand Down Expand Up @@ -610,7 +612,7 @@ func verifyAppPodRunning(appname string) {
gomega.Eventually(func() bool {
appPod, err = PodClient.WithNamespace(OpenEBSNamespace).
List(metav1.ListOptions{
LabelSelector: "app=busybox,appName=" + appname,
LabelSelector: "role=test,appName=" + appname,
})
gomega.Expect(err).ShouldNot(gomega.HaveOccurred(), "while verifying application pod")
return len(appPod.Items) == 1
Expand Down